Pre-allocate space for the display to stop memory fragmentation#41
Open
divereigh wants to merge 1 commit intofurbrain:mainfrom
Open
Pre-allocate space for the display to stop memory fragmentation#41divereigh wants to merge 1 commit intofurbrain:mainfrom
divereigh wants to merge 1 commit intofurbrain:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found the SAP6 frequently crashes after a it has received a few errors with a memory allocation error. This is very irritating because invariably SexyTopo loses contact with the SAP6.
I let chatGPT loose on the problem and it said the issue is related to allocation of the display error messages, which then can end up fragmenting the memory. It suggested the attached fixes to essentially allocate the memory ahead of time.
It appears that now the display still includes the bluetooth and battery symbol even when displaying the big text, so I modified the error messages slightly so they don't look awful.
I can confirm this does seem to fix the crashing issue. But I am unsure if it creates any others.