Folia 26.1.2 Support#25
Conversation
…ream Main upstream
(JM is not working, as I know :) )
This reverts commit 02ca70a.
…to funniray-main
… handling - Added new plugin message channels for JourneyMap and Xaeros integration. - Refactored player join handling to send initial state and permissions. - Introduced a method for sending multiple plugin messages at once. - Updated JMHandler to manage multiplayer options and admin requests more effectively. - Improved version handling and permissions management for players. - Enhanced VoxelHandler and XaerosHandler to support new configuration options. - Updated Gradle wrapper to version 9.4.1 and adjusted dependencies for compatibility. - Refined Spigot integration to ensure proper task scheduling and player message handling. - Added plugin.yml for Spigot plugin metadata and permissions configuration.
funniray
left a comment
funniray
left a comment
There was a problem hiding this comment.
Please also rebase/merge this PR on the current git history
|
|
||
| public void handleMPOptions(MinimapPlayer player, byte[] message) { | ||
| if (message.length > 0) { | ||
| player.sendMessage(MiniMessage.miniMessage().deserialize("<red>Saving JourneyMap multiplayer options is not implemented.")); |
There was a problem hiding this comment.
What's the point in even implementing this packet if we're not saving the data?
| case "mp_options_req": | ||
| handleMPOptions(player, message); | ||
| break; | ||
| case "common": |
There was a problem hiding this comment.
We shouldn't blatantly remove support for 1.16 versions. At the very least, we should still be sending permissions.
| } | ||
|
|
||
| private void writeCurrentNbt(CompoundBinaryTag tag, ByteArrayDataOutput out) throws IOException { | ||
| BinaryTagIO.writer().writeNameless(tag, out); |
There was a problem hiding this comment.
On versions before 1.20.3, we should just call .write() instead of .writeNameless()
| repositories { | ||
| mavenCentral() | ||
| maven { | ||
| url = uri("https://repo.papermc.io/repository/maven-public/") |
There was a problem hiding this comment.
common should not depend on paper at all.
| } | ||
|
|
||
| val javaTarget = 8 // Sponge targets a minimum of Java 17 | ||
| val javaTarget = 25 |
There was a problem hiding this comment.
We should stay on Java 8, or 17 at most
| if (player.isOnline()) { | ||
| this.handlePlayerJoinedRepeat(new SpigotPlayer(player)); | ||
| } | ||
| }, null, 40L, 40L); |
There was a problem hiding this comment.
Are we sending plugin messages every 2 seconds?
| } | ||
|
|
||
| val javaTarget = 11 | ||
| val javaTarget = 25 |
There was a problem hiding this comment.
we should keep the requirements as spigot 1.16 and java 11 as a minimum.
| exclude("org/apache/commons/**") | ||
| exclude("org/yaml/snakeyaml/**") | ||
| archiveBaseName.set("${rootProject.name}-spigot") | ||
| archiveBaseName.set("minimap-control-folia") |
There was a problem hiding this comment.
This shouldn't be explicitly named folia
There was a problem hiding this comment.
we shouldn't remove the gradle wrapper
| rootProject.name = "minimap" | ||
| include("common") | ||
| include("sponge") | ||
| //include("sponge") |
3 participants
No description provided.