Add c++ name mangling to avoid keyword collision#50
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 95.03% 95.11% +0.07%
==========================================
Files 12 12
Lines 383 389 +6
==========================================
+ Hits 364 370 +6
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
thanks @cmalinmayor! I'll have a look at this today (if the test failures are unrelated, let me just touch up the repo again) |
|
Claude says witty needs typing_extensions in it's dependencies, hence the failures that are on main. Seems like the fix doesn't actually work on the Windows CI though (I couldnt' test locally), so I'll need to iterate |
|
ok, I'll do the updates in parallel |
|
Alright the fix seems to work now, and the general approach of mangling c++ keywords that are passed from user-specified attributes into the c++ template seems like a good idea to avoid other unforeseen issues |
|
thanks @cmalinmayor, good fix 👍 |
|
just pushed tag v0.0.6 ... so this should be released shortly |
https://github.com/live-image-tracking-tools/geff/actions/runs/26179372787/job/77017880290
28 compilation failures in our GEFF windows tests, where apparently we call an attribute
uint16and windows c++ breaks on keyword collision - Claude suggested adding this attribute name mangling to the c++ side only, avoiding keyword collision without affecting the public Python API