Aligned Orthogonal Views #103
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmalinmayor
reviewed
Sep 8, 2025
| res_layer.metadata["viewer_name"] = name | ||
| return res_layer | ||
|
|
||
| # do not let ruff move these import statements! |
Contributor
There was a problem hiding this comment.
Put in a # noqa on these lines so it happens automatically
cmalinmayor
reviewed
Sep 8, 2025
| copied_layer.mouse_drag_callbacks.append(click_wrapper) | ||
|
|
||
| # Bind keys to original layer TracksViewer | ||
| copied_layer.bind_key("q")(orig_layer.tracks_viewer.toggle_display_mode) |
Contributor
There was a problem hiding this comment.
Can we make these variables on the tracks controller so at least we have them defined in one place (or make an issue for it and we can do it later)
cmalinmayor
reviewed
Sep 8, 2025
pyproject.toml
Outdated
| "fonticon-fontawesome6", | ||
| "zarr<3", | ||
| "imagecodecs", # for unzipping sample data | ||
| "napari-orthogonal-views @ git+https://github.com/AnniekStok/napari-orthogonal-views.git@main" |
Contributor
There was a problem hiding this comment.
Make a tag/release on your github so we can point to a specific named instead of a moving branch.
cmalinmayor
requested changes
Sep 8, 2025
Contributor
cmalinmayor
left a comment
cmalinmayor
left a comment
There was a problem hiding this comment.
Important changes: depending on a specific tag. testing drawing in 3D in 2D data (and maybe just say no).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Change
Option to display canvas-aligned orthogonal views. All interactive functionality (painting, selecting nodes, changing tool modes, undo/redo) should sync between the different viewers.
Checklist
Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.
Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...