科目一覧を syllabus_id 昇順で返却#50
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
masaya-osuga
approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
GET /v1/subjects の返却順がDB依存で不安定だった点を解消し、サーバ側で一貫した並び順(syllabus_id 昇順)を保証するための変更です。
Changes:
SubjectRepository.ListのクエリにORDER BY syllabus_id ASCを追加し、科目一覧の順序を安定化
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
GET /v1/subjects(科目一覧取得)はリポジトリ層でORDER BYを指定しておらず、DB が返す順序(実質未定義)で結果を返していた。クライアント側での並び順が安定しないため、サーバ側で一貫した順序を保証する必要がある。変更点
internal/repository/subject.goのSubjectRepository.Listにおいて、Find実行前にOrder("syllabus_id ASC")を追加し、科目一覧をsyllabus_id昇順で返却するようにした。確認内容
GET /v1/subjectsのレスポンスがsyllabus_id昇順で並んでいることq/year/gradesなどのフィルタ併用時も順序が維持されること🤖 Generated with Claude Code