Fix: Remove macros from namespace when deleted #209
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a macro via
del model.macro_name, it was removed from_macrosdict but persisted in_macro_namespace, causing stale references.Changes
del_macro()to also remove the macro from_macro_namespacewhen presenttest_macro_delete()to verify namespace cleanupExample
The fix handles the lazy initialization of
_macro_namespace(only created on first macro execution) by checking forNonebefore attempting deletion.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.