Feat: Add return union types support#115
Merged
tcampbPPU merged 3 commits intofumeapp:masterfrom Feb 17, 2026
Merged
Conversation
Member
|
TIL ReflectionUnionType |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for return union types. E.g. returning:
string|int|nullwould make the TS file would havestring | number | nullas the type.Problem
Previously, having a PHP union return type gets converted to
unknownas the return type.This:
Becomes this:
score_nullable: unknownThat causes some issues in TypeScript code expecting a more properly defined type.
Solution
This PR adds a section to handle when the reflection return type is ReflectionUnionType and loop through each return type to map them to TypeScript
src/Actions/WriteColumnAttribute.phpTests
Tests have been added and updated existing expectations to keep previous tests working.
Thank you!