fix(solution): register missing Quota project in FSH.Starter.slnx (resolves NU1105)#1296
Open
sabinshrestha wants to merge 1 commit into
Open
fix(solution): register missing Quota project in FSH.Starter.slnx (resolves NU1105)#1296sabinshrestha wants to merge 1 commit into
sabinshrestha wants to merge 1 commit into
Conversation
Added Quota.csproj to solution with Debug build config. Marked multiple dependencies as peer in package-lock.json. Updated some package versions (e.g., react, vite).
Author
|
Issue Fixes #1291 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a
NU1105restore cascade that breaksdotnet restoreand Visual Studio's open ofsrc/FSH.Starter.slnxon a fresh clone.src/BuildingBlocks/Quota/Quota.csprojexists on disk and is referenced via<ProjectReference>from several projects (Storage,Web,Framework.Tests,Modules.Billing), but it was never added to the solution. NuGet restore therefore can't walk the project graph and emitsNU1105for every project that depends on those four — which cascades to nearly every module, host, and test project.Root cause
src/FSH.Starter.slnxwas missing the entry below under the/BuildingBlocks/folder:Fix
Added the
Quotaproject to the solution in its alphabetical position (betweenPersistenceandShared).Verification
dotnet restore src/FSH.Starter.slnx→ "All projects are up-to-date for restore."NU1105entries gone after reopening the solution.Suggested follow-up (out of scope for this PR)
Add a CI check that every
<ProjectReference>-referenced.csprojis a member ofFSH.Starter.slnx, so this kind of drift is caught automatically. A small script that diffsdotnet sln listagainst the union of allProjectReferencepaths would do it.