feat(clients): use official FSH favicon in admin and dashboard#1289
Merged
Conversation
Replace the placeholder favicon.svg in both apps with the official fullstackhero favicon set (favicon.ico + 16x16/32x32 PNGs), matching the docs site's canonical brand assets. Update each index.html to link the .ico + PNG set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Both the admin and dashboard apps were shipping placeholder
favicon.svgfiles (a generic "H" mark in admin, a chart-line in dashboard) — neither was the FullStackHero brand. This swaps in the official FSH favicon set.Changes
public/in bothclients/adminandclients/dashboard:favicon.icofavicon-32x32.pngfavicon-16x16.pngfullstackhero/docs), the same source as the existinglogo-fullstackhero.png(byte-identical).favicon.svgfrom both apps.index.htmlto link the.ico+ PNG set instead of the old SVG.All three surfaces (docs, admin, dashboard) now share one favicon — the green chevron FSH mark.
Notes
.ico+ PNGs rather than inventing a vector.🤖 Generated with Claude Code