Skip to content

Add pre-flight and post-flight release procedures to cutting-releases skill#1709

Open
waynesun09 wants to merge 5 commits into
mainfrom
update-release-skill
Open

Add pre-flight and post-flight release procedures to cutting-releases skill#1709
waynesun09 wants to merge 5 commits into
mainfrom
update-release-skill

Conversation

@waynesun09
Copy link
Copy Markdown
Contributor

@waynesun09 waynesun09 commented May 29, 2026

Summary

  • Adds pre-flight release check section: diff reusable workflows, scaffold templates, and CLI changes against the v0 tag to detect breaking changes before tagging
  • Adds v0 tag move step and workflow wait step to the release process (steps 8-9), renumbers remaining steps
  • Adds post-flight verification section: check downstream orgs, retrigger failed runs, present summary
  • Variable-dependent commands (org names, repo names, run IDs) prompt the user via AskUserQuestion rather than assuming values are available

Test plan

  • Read through the updated SKILL.md and verify the flow is logical
  • Confirm make lint passes (verified locally)
  • Dry-run the pre-flight section against the current v0 tag
  • Verify allowed-tools list includes all commands used in new sections

@waynesun09
feat(skill): add pre-flight and post-flight release procedures
f453ab1 
The cutting-releases skill now covers the full release lifecycle:

Pre-flight: diff reusable workflows, scaffold templates, and CLI
changes against the v0 tag to detect breaking changes before release.

Process: added v0 tag move (step 8) and workflow wait (step 9),
renumbered remaining steps.

Post-flight: verify downstream orgs resolve @v0 correctly, retrigger
failed runs for confirmation, present summary table.

All variable-dependent commands prompt the user via AskUserQuestion
rather than assuming values are in the environment.

Signed-off-by: Wayne Sun <gsun@redhat.com>
@waynesun09 waynesun09 requested a review from ralphbean May 29, 2026 21:08
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026 •
edited
Loading

Site preview

Preview: https://2c11db53-site.fullsend-ai.workers.dev

Commit: 2812a346113e986c9abd8559ca1118c9cb66c820

@waynesun09
fix(skill): add git fetch before pre-flight diffs, drop unused lint tool
65c9dfb 
Pre-flight steps use origin/main refs but ran before the pull step.
Add explicit git fetch at the top of pre-flight to ensure fresh state.
Remove Bash(make lint:*) from allowed-tools since it is not referenced
in any skill step.

Signed-off-by: Wayne Sun <gsun@redhat.com>
waynesun09
waynesun09 commented May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@waynesun09 waynesun09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Findings

Medium

  • [correctness] skills/cutting-releases/SKILL.md:28 — Pre-flight steps A–C diff against origin/main but the pre-flight section runs before step 1 (git checkout main && git pull). Stale origin/main produces wrong diffs.
    Remediation: Added git fetch origin at the top of the pre-flight section. Fixed in 65c9dfb.

Low

  • [hygiene] skills/cutting-releases/SKILL.md:7 — Bash(make lint:*) was in allowed-tools but never referenced in any skill step. Unused tool permissions widen the surface for no benefit.
    Remediation: Removed from allowed-tools. Fixed in 65c9dfb.

@fullsend-ai-review
Copy link
Copy Markdown

fullsend-ai-review Bot commented May 29, 2026 •
edited
Loading

Review

Findings

Low

  • [redundant-check] skills/cutting-releases/post-flight.md:37 — Post-flight section C checks gh run list --repo fullsend-ai/fullsend, but section A already verifies the release workflow in the same repo via gh run list --workflow=release.yml. The fullsend-ai/fullsend line in section C is redundant with section A and could be removed, keeping only actual downstream consumers like fullsend-ai/.fullsend.
    Remediation: Remove the fullsend-ai/fullsend line from section C, since that repo's release workflow is already verified in section A.
Previous run

Review

Findings

Low

  • [redundant-check] skills/cutting-releases/post-flight.md:37 — Post-flight section C checks gh run list --repo fullsend-ai/fullsend, but section A already verifies the release workflow in the same repo via gh run list --workflow=release.yml. The fullsend-ai/fullsend line in section C is redundant with section A and could be removed, keeping only actual downstream consumers like fullsend-ai/.fullsend.
    Remediation: Remove the fullsend-ai/fullsend line from section C, since that repo's release workflow is already verified in section A.
Previous run (2)

Review

Findings

High

  • [protected-path] skills/cutting-releases/SKILL.md — This PR modifies a file under skills/, which is a protected path requiring human approval. The PR has no linked issue authorizing this change. While the PR description explains the additions (pre-flight and post-flight release procedures), protected-path changes require a linked issue to establish authorization.
    Remediation: Link an issue that authorizes changes to the cutting-releases skill, or have a maintainer confirm the change is authorized.

Info

  • [correctness] skills/cutting-releases/SKILL.md — The content additions are technically sound. The allowed-tools frontmatter correctly adds Bash(git fetch:*) for the new git fetch origin command. The gh run rerun command in post-flight is covered by the existing Bash(gh run:*) pattern. Step renumbering is consistent. Pre-flight audit checklists (reusable workflows, scaffold templates, CLI changes) and post-flight verification steps are well-structured and cover the right areas.
Previous run (3)

Review

Findings

No findings.

The pre-flight and post-flight sections are well-structured and follow the existing skill patterns. Step renumbering is correct, the allowed-tools addition of git fetch is necessary and appropriate, and the AskUserQuestion gates in the post-flight section ensure user confirmation before retriggering runs or proceeding with verification.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 29, 2026
@waynesun09
refactor(skill): deepen pre-flight analysis and scope post-flight checks
1b87ea9 
Pre-flight now audits workflow inputs/outputs/secrets/permissions,
reads CLI function diffs for behavioral changes, and identifies
post-flight check areas to focus verification.

Post-flight now waits for CI workflows first, checks fullsend-ai
repos by default (always accessible to repo admins), and only asks
about additional downstream repos the user has access to. Removed
duplicate wait/verify steps from the process section.

Signed-off-by: Wayne Sun <gsun@redhat.com>
fullsend-ai-review[bot]
fullsend-ai-review Bot suggested changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown

@fullsend-ai-review fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label May 29, 2026
@waynesun09
refactor(skill): split cutting-releases into phase files
bf67447 
Extract pre-flight and post-flight procedures into separate files
for progressive disclosure. SKILL.md routes to each phase file
with Read instructions.

- SKILL.md: 152 lines (overview + process steps 1-10 + notes)
- pre-flight.md: 122 lines (audit steps A-F)
- post-flight.md: 89 lines (verification steps A-E)

Each file stays under 150 lines. No content loss — just
reorganization.

Signed-off-by: Wayne Sun <gsun@redhat.com>
@waynesun09
fix(skill): address review findings — confirm force-push, trim to 150…
2812a34 
… lines, add grep backstop

- Add AskUserQuestion gate before force-pushing v0 tag (step 8)
- Name AskUserQuestion explicitly in step 10
- Trim SKILL.md to 149 lines (was 156) by condensing verbose sections
- Add grep backstop in pre-flight step A for mechanical verification
  of removed/renamed workflow identifiers

Signed-off-by: Wayne Sun <gsun@redhat.com>
fullsend-ai-review[bot]
fullsend-ai-review Bot approved these changes May 29, 2026
View reviewed changes
Comment thread skills/cutting-releases/post-flight.md
The skill user is a fullsend repo admin, so fullsend-ai org repos
are always accessible. Check recent workflow runs in the org's repos
that consume `@v0` reusable workflows:

Copy link
Copy Markdown

@fullsend-ai-review fullsend-ai-review Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] redundant-check

Post-flight section C checks gh run list --repo fullsend-ai/fullsend, but section A already verifies the release workflow in the same repo. The fullsend-ai/fullsend line in section C is redundant and could be removed, keeping only downstream consumers like fullsend-ai/.fullsend.

Suggested fix: Remove the fullsend-ai/fullsend line from section C, since that repo's release workflow is already verified in section A.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 29, 2026
fullsend-ai-review[bot]
fullsend-ai-review Bot approved these changes May 29, 2026
View reviewed changes
Comment thread skills/cutting-releases/post-flight.md
The skill user is a fullsend repo admin, so fullsend-ai org repos
are always accessible. Check recent workflow runs in the org's repos
that consume `@v0` reusable workflows:

Copy link
Copy Markdown

@fullsend-ai-review fullsend-ai-review Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] redundant-check

Post-flight section C checks gh run list --repo fullsend-ai/fullsend, but section A already verifies the release workflow in the same repo via gh run list --workflow=release.yml. The fullsend-ai/fullsend line in section C is redundant with section A and could be removed, keeping only actual downstream consumers like fullsend-ai/.fullsend.

Suggested fix: Remove the fullsend-ai/fullsend line from section C, since that repo's release workflow is already verified in section A.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralphbean ralphbean Awaiting requested review from ralphbean

1 more reviewer

@fullsend-ai-review fullsend-ai-review[bot] fullsend-ai-review[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waynesun09