fix(#1697): add force-override logging and regression tests#1698
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#1697): add force-override logging and regression tests#1698fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add diagnostic logging when pre-code.sh evaluates the --force override so COMMENT_BODY value is visible in workflow run logs, making future debugging straightforward. Rename the COMMENT_BODY variable used to build the skip comment (line 104) to SKIP_COMMENT to eliminate the name collision with the input COMMENT_BODY env var. While this didn't cause the reported regression (the force check runs before the reassignment), the shadowing is a latent bug if code is reordered. Add four regression tests to pre-code-test.sh: - force-comment-body-no-pr-search: verifies COMMENT_BODY with --force exits before PR search - force-code-force-no-pr-search: verifies CODE_FORCE=true exits before PR search - force-check-logs-comment-body: verifies the new diagnostic log line appears in output - no-force-reaches-pr-search: verifies without --force the PR search IS reached (no false bypass) Note: pre-commit could not run (Go toolchain download permission denied in sandbox). All 17 pre-code-test.sh tests pass. Closes #1697 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
Site previewPreview: https://3934aea3-site.fullsend-ai.workers.dev Commit: |
ReviewNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add diagnostic logging when pre-code.sh evaluates the --force override so COMMENT_BODY value is visible in workflow run logs, making future debugging straightforward.
Rename the COMMENT_BODY variable used to build the skip comment (line 104) to SKIP_COMMENT to eliminate the name collision with the input COMMENT_BODY env var. While this didn't cause the reported regression (the force check runs before the reassignment), the shadowing is a latent bug if code is reordered.
Add four regression tests to pre-code-test.sh:
--force exits before PR search
before PR search
log line appears in output
search IS reached (no false bypass)
Note: pre-commit could not run (Go toolchain download permission denied in sandbox). All 17 pre-code-test.sh tests pass.
Closes #1697
Post-script verification
agent/1697-force-flag-regression)c9f4660fdf0e2639f42eb3aae7bfa0a8c114b4ee..HEAD)