Skip to content

docs(#1662): ADR 0043 — require authorization on all slash commands#1688

Open
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
agent/1662-adr-auth-slash-commands
Open

docs(#1662): ADR 0043 — require authorization on all slash commands#1688
fullsend-ai-coder[bot] wants to merge 2 commits into
mainfrom
agent/1662-adr-auth-slash-commands

Conversation

@fullsend-ai-coder
Copy link
Copy Markdown

Add ADR proposing that /fs-triage, /fs-code, and /fs-review use the same is_authorized gate already enforced by /fs-fix, /fs-retro, and /fs-prioritize. The ADR addresses the four design questions from the issue: automatic event triggers remain ungated, bot-to-bot workflows are preserved via the existing Bot-type bypass, unauthorized users see silent failure (consistent with existing gated commands), and is_authorized is a platform-level boundary not overridable per-repo.

Note: make lint could not run due to sandbox Go toolchain permission error. ADR-specific linters (lint-adr-frontmatter, lint-adr-numbers, lint-adr-status) all passed.


Closes #1662

Post-script verification

  • Branch is not main/master (agent/1662-adr-auth-slash-commands)
  • Secret scan passed (gitleaks — 11cdd7674a31c564785e9daa2efaf7b931385e1c..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

Site preview

Preview: https://8eefdf73-site.fullsend-ai.workers.dev

Commit: dca81386536c432d2ab4c12467c83211b0ea7cf4

@fullsend-ai-review
Copy link
Copy Markdown

fullsend-ai-review Bot commented May 29, 2026

Review

Findings

No findings.

The ADR accurately describes the current authorization gap — verified against reusable-dispatch.yml that /fs-triage, /fs-code, and /fs-review lack the is_authorized gate present on /fs-fix, /fs-retro, and /fs-prioritize. The proposed solution is consistent and addresses all four design questions from #1662: automatic triggers are gated by actor association, bot-to-bot workflows are preserved via the existing COMMENT_USER_TYPE != "Bot" bypass, unauthorized users receive visible feedback, and is_authorized is a non-overridable platform boundary. ADR number 0043 is sequential with no conflicts.

Previous run

Review

Findings

No findings.

The ADR is well-structured, addresses all four design questions from the linked issue (#1662), and proposes a consistent authorization pattern across all slash commands. Cross-references to ADR 0034, ADR 0042, and the security threat model are valid. The automatic-event and bot-bypass carve-outs are clearly scoped and well-reasoned. No existing documentation is made stale by this change.

Previous run (2)

Review

Findings

No findings.

The ADR is well-structured, factually accurate, and fully addresses all four design questions from #1662 (automatic event triggers, bot-to-bot workflows, error messaging, per-repo configurability). The authorization gating table was verified against reusable-dispatch.yml — the claimed gated/ungated status for each slash command is correct. Cross-references to ADR 0034 and ADR 0042 are valid. Frontmatter and section format are consistent with existing ADRs.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label May 29, 2026
@ascerra ascerra force-pushed the agent/1662-adr-auth-slash-commands branch from eee399d to 27584e3 Compare May 29, 2026 14:27
@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 29, 2026
Comment thread docs/ADRs/0043-require-authorization-on-all-slash-commands.md Outdated
Comment thread docs/ADRs/0043-require-authorization-on-all-slash-commands.md Outdated
Comment thread docs/ADRs/0043-require-authorization-on-all-slash-commands.md Outdated
fullsend-code and others added 2 commits May 29, 2026 11:58
Add ADR proposing that /fs-triage, /fs-code, and /fs-review use the
same is_authorized gate already enforced by /fs-fix, /fs-retro, and
/fs-prioritize. The ADR addresses the four design questions from the
issue: automatic event triggers remain ungated, bot-to-bot workflows
are preserved via the existing Bot-type bypass, unauthorized users
see silent failure (consistent with existing gated commands), and
is_authorized is a platform-level boundary not overridable per-repo.

Note: make lint could not run due to sandbox Go toolchain permission
error. ADR-specific linters (lint-adr-frontmatter, lint-adr-numbers,
lint-adr-status) all passed.

Closes #1662

Signed-off-by: Adam Scerra <ascerra@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Address reviewer feedback:
- Expand scope from slash commands to all dispatch paths (including
  issues.opened and pull_request_target.opened)
- Replace silent failure with visible feedback for unauthorized users
- Remove #553 reference (tangential), keep #877
- Rename file to match updated title

Signed-off-by: Adam Scerra <ascerra@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADR: require is_authorized check on all agent slash commands

2 participants