Skip to content

docs: remove Proposed and Undecided as valid ADR statuses#1680

Open
ralphbean wants to merge 1 commit into
mainfrom
docs/remove-proposed-adr-status
Open

docs: remove Proposed and Undecided as valid ADR statuses#1680
ralphbean wants to merge 1 commit into
mainfrom
docs/remove-proposed-adr-status

Conversation

@ralphbean
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • python3 hack/lint-adr-frontmatter passes all 41 ADRs
  • make lint passes
  • Rebased cleanly on latest main (including the 0028 change)

🤖 Generated with Claude Code

Valid ADR statuses are now Accepted, Deprecated, and Superseded.
All 11 ADRs previously in Proposed status are moved to Accepted.
Updates lint rules, template, ADR 0001, README, skill docs, and
the agent-execution-environment plan to match.

0028 (GitLab support) is excluded — it is being updated separately.

Assisted-by: Claude claude-opus-4-6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@github-actions
Copy link
Copy Markdown

Site preview

Preview: https://748b92db-site.fullsend-ai.workers.dev

Commit: 2c891936cabbf91203cd40ebf6c106a2ba0e94fe

@fullsend-ai-review
Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] skills/writing-adrs/SKILL.md — This PR modifies a file under skills/, which is a protected path requiring human approval. The PR has no linked issue providing authorization for changes to governance/infrastructure files. The change itself is consistent with the rest of the PR (removing references to Proposed/Undecided statuses), but human review and approval is required for protected-path modifications.
    Remediation: Link an issue authorizing the skills/ change, or obtain explicit human approval on this PR.

Info

  • [correctness] All 12 ADRs with status: Proposed on main are updated to Accepted in both frontmatter and ## Status section. The template (0000), lint scripts (hack/lint-adr-frontmatter, hack/util/get-adr-status.sh), README, ADR 0001, writing-adrs skill, and agent-execution-environment plan are all updated consistently. No remaining references to Proposed or Undecided as ADR statuses were found outside the files modified by this PR (other uses of "Proposed" in the repo are regular English, not ADR status values).

Copy link
Copy Markdown

@fullsend-ai-review fullsend-ai-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant