fix(#1667): make bot-exclusion tests exercise the jq filter#1669
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#1667): make bot-exclusion tests exercise the jq filter#1669fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The mock gh in pre-code-test.sh returned pre-configured output directly, bypassing --jq entirely. Bot-exclusion tests fed already-filtered (empty) output, so the jq select() filter in pre-code.sh was never exercised — they were functionally identical to the no-existing-prs-proceeds test. Changes: - Enhance mock gh to parse --jq from arguments and pipe output through jq, matching real gh CLI behavior - Convert all test inputs from pre-filtered tab-separated text to unfiltered JSON arrays - bot-pr-does-not-block now provides a fullsend-ai[bot] PR and verifies the jq filter removes it - coder-bot-pr-does-not-block now provides a fullsend-ai-coder[bot] PR and verifies filtering - coder-bot-pr-plus-human-pr-blocks now provides a mix of bot and human PRs, verifying only bots are filtered - Add both-bots-do-not-block test for the case where both bot types are present with no human PRs Closes #1667 Signed-off-by: fullsend-code <fullsend-code@users.noreply.github.com>
Site previewPreview: https://942f132b-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mock gh in pre-code-test.sh returned pre-configured output directly, bypassing --jq entirely. Bot-exclusion tests fed already-filtered (empty) output, so the jq select() filter in pre-code.sh was never exercised — they were functionally identical to the no-existing-prs-proceeds test.
Changes:
output through jq, matching real gh CLI behavior
text to unfiltered JSON arrays
and verifies the jq filter removes it
fullsend-ai-coder[bot] PR and verifies filtering
bot and human PRs, verifying only bots are filtered
bot types are present with no human PRs
Closes #1667
Post-script verification
agent/1667-fix-bot-exclusion-tests)ca58e069568170fb9d00d8ef7c06ed4caefd6fd2..HEAD)