docs: surface ADR rules in AGENTS.md and clarify PR status#1661
Open
ifireball wants to merge 1 commit into
Open
docs: surface ADR rules in AGENTS.md and clarify PR status#1661ifireball wants to merge 1 commit into
ifireball wants to merge 1 commit into
Conversation
Agents load AGENTS.md by default but ADR immutability lived only in the writing-adrs skill. Document core ADR conventions for all agents and align the skill with merge-as-approval (default new ADRs to Accepted when ready). Fixes fullsend-ai#1648 Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Barak Korren <bkorren@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ifireball
force-pushed
the
cursor/daac3fe8
branch
from
de36dc0 to
8de0cf2
Compare
Site previewPreview: https://f5aeaa6c-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Contributor
Author
|
/fs-retro review agent should not set ready-for-merge when changing repo rules like this |
ralphbean
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdso all agents see immutability, PR review, and review expectations without invoking thewriting-adrsskill.skills/writing-adrs/SKILL.mdto treat merge as approval: new ADRs ready for review should default to Accepted, not Proposed, when the decision is made.Closes #1648.
Test plan
AGENTS.mdrenders the new section and link towriting-adrsAGENTS.mdmake lint(ADR frontmatter unchanged; docs-only)Made with Cursor