Skip to content

fix(dispatch): route issues opened/edited to triage in per-repo mode#1652

Open
rh-hemartin wants to merge 1 commit into
mainfrom
fix/per-repo-triage-on-issue-open
Open

fix(dispatch): route issues opened/edited to triage in per-repo mode#1652
rh-hemartin wants to merge 1 commit into
mainfrom
fix/per-repo-triage-on-issue-open

Conversation

@rh-hemartin
Copy link
Copy Markdown
Contributor

Summary

  • reusable-dispatch.yml was missing the opened|edited → triage branch in the issues) routing case
  • Org-mode dispatch.yml has had this routing since the feature was introduced; per-repo was an omission from the original implementation (3bcd099e)
  • The shim (shim-per-repo.yaml) already subscribes to issues: [opened, edited, labeled] — only the dispatch routing logic needed updating

Fixes #1241

Test plan

  • Open an issue in a per-repo-enrolled repository — triage agent should trigger
  • Edit an issue in a per-repo-enrolled repository — triage agent should trigger
  • Add ready-to-code label — code agent should still trigger (no regression)
  • Add ready-for-review label — review agent should still trigger (no regression)

🤖 Generated with Claude Code

Per-repo reusable-dispatch.yml was missing the opened|edited → triage
branch in the issues) case. Org-mode dispatch.yml has had this routing
since the feature was introduced; per-repo was an omission from the
original implementation (3bcd099).

Fixes #1241

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Hector Martinez <hemartin@redhat.com>
@github-actions
Copy link
Copy Markdown

Site preview

Preview: https://c99fd2d8-site.fullsend-ai.workers.dev

Commit: 28ed9d15d6f4a210be3d5ae19864cd898f7d7df2

@fullsend-ai-review
Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/workflows/reusable-dispatch.yml — This PR modifies a file under .github/, which is a protected path requiring human approval. The change is well-justified (linked issue dispatch: per-repo install does not trigger triage on issue open #1241, clear rationale for adding the missing opened|edited → triage routing to match org-mode behavior), but human review and approval is always required for protected-path changes regardless of context.

The code change itself is correct: the new if/elif structure matches the org-mode dispatch.yml pattern exactly, the shim already subscribes to issues: [opened, edited, labeled], and the existing labeled routing is preserved via elif. No correctness, security, injection, or documentation staleness concerns identified.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label May 28, 2026
@rh-hemartin rh-hemartin self-assigned this May 28, 2026
Copy link
Copy Markdown
Contributor

@ralphbean ralphbean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dispatch: per-repo install does not trigger triage on issue open

2 participants