fix: stabilize local model review flow#16
Merged
Conversation
Owner
Author
|
@claude please review |
- Promote "all" platform sentinel to ALL_PLATFORMS constant in models. - Promote embedding-model exclusion list to EMBEDDING_MODEL_MARKERS. - Drop unreachable branch in fenced-JSON candidate extractor. - Cache escapeHtml output per option in populateModelOptions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
adlint/static/app.jsadds timeout-controlled/analyzefetches, model option population, and review-model filtering.adlint/static/index.htmlchanges model selection to a dropdown and adds theAllplatform option.adlint/policy.pyandadlint/rules/engine.pymakeplatform=allinclude platform-scoped policies and LinkedIn derived rules.adlint/classifiers/ollama.pysendsthink: falseand accepts fenced JSON responses from local models.Makefilestarts the local API with bounded Ollama timeout and token generation settings.Test plan
make testADLINT_OLLAMA_TIMEOUT=180 ADLINT_OLLAMA_NUM_PREDICT=1024:gpt-oss-safeguard:20b,gpt-oss:20b,qwen3-coder:30b,qwen3.5:35b-a3b, andgemma4:26ball returnedmodel.status: okhttp://127.0.0.1:8000/ui/withgpt-oss-safeguard:20breturningmodel.status: okgemma4:26breturningmodel.status: okNotes
adlint.model_review.v1schema.