Fix GitHub tests without a network connection #509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapper is supposed to catch connection errors and turn them into `xfail`, but `test_rmdir_not_empty` _also_ catches connection errors because they are `OSError` (which is what it expect, thus the test still fails everything. Instead, change the `xfail_on_github_rate_limit` function to check for networking first, and mark everything `xfail` directly. Also, remove the `_xfail_on_rate_limit_errors` fixture, which is redundant to the above and doesn't work fully because it only applies to the class's direct test methods and not its inherited test methods.
Collaborator
|
Hi @QuLogic thank you for your contribution. I can still generate transient errors with your implementation when rerunning the checks over and over. I'll push a quick update to your PR, let me know if that solves the issue for you |
Collaborator
|
I'm merging this to continue with other test refactors. We can open another PR in case it's not sufficient. Thanks again 🙏 |
Contributor
Author
|
No, sorry, this is much worse. Now all tests in the file fail without a network connection instead of just |
Collaborator
|
Sorry to hear. Can you provide some information about your system and a full traceback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper is supposed to catch connection errors and turn them into
xfail, buttest_rmdir_not_emptyalso catches connection errors because they areOSError(which is what it expect, thus the test still fails everything.)Instead, change the
xfail_on_github_rate_limitfunction to check for networking first, and mark everythingxfaildirectly.Also, remove the
_xfail_on_rate_limit_errorsfixture, which is redundant to the above and doesn't work fully because it only applies to the class's direct test methods and not its inherited test methods.