Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Dec 26, 2025

This refactors genBinding to move the actual workaround we have for tuples.

Concretely, we have this for:

        let var1withAVeryLongLongLongLongLongLongName, var2withAVeryLongLongLongLongLongLongName = // foo
            someFunc 1, someFunc 2

we need to wrap (var1, var2) into parentheses to remain valid code.

But we were repeating a bit too much code in genBinding to deal with this.

@nojaf nojaf requested a review from dawedawe December 26, 2025 08:59
Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@nojaf nojaf merged commit ec740da into fsprojects:main Dec 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants