Switch to use paket tool#17
Open
wallymathieu wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s build/dependency bootstrap flow to use Paket as a .NET tool (and removes the previous build.proj-based restore entrypoint).
Changes:
- Replace
dotnet restore build.projwithdotnet tool restore+dotnet paket restorein the build scripts. - Add a .NET tool manifest for
paketandfake-cli. - Update
.paket/Paket.Restore.targets(likely regenerated) and remove the now-unusedbuild.projand rootpaket.referencesentry.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| paket.references | Removes the root-level reference (previously dotnet-fake). |
| paket.lock | Updates dependency restriction entries (lockfile regeneration). |
| dotnet-tools.json | Adds local .NET tool manifest for Paket + FAKE. |
| build.sh | Switches restore step to dotnet tool restore / dotnet paket restore. |
| build.proj | Removes MSBuild entrypoint previously used for restore/build orchestration. |
| build.fsx | Adds an explicit type annotation to getProjectDetails parameter. |
| build.cmd | Switches restore step to dotnet tool restore / dotnet paket restore. |
| .paket/Paket.Restore.targets | Updates Paket MSBuild restore/pack integration logic (newer targets). |
| .paket/.gitignore | Removes ignore rule for paket.exe. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+10
| dotnet tool restore | ||
| dotnet paket restore |
Comment on lines
+4
to
+5
| dotnet tool restore | ||
| dotnet paket restore |
Comment on lines
+68
to
+71
| <PropertyGroup Condition=" '$(PaketExePath)' == '' "> | ||
| <_DotnetToolsJson Condition="Exists('$(PaketRootPath)/.config/dotnet-tools.json')">$([System.IO.File]::ReadAllText("$(PaketRootPath)/.config/dotnet-tools.json"))</_DotnetToolsJson> | ||
| <_ConfigContainsPaket Condition=" '$(_DotnetToolsJson)' != ''">$(_DotnetToolsJson.Contains('"paket"'))</_ConfigContainsPaket> | ||
| <_ConfigContainsPaket Condition=" '$(_ConfigContainsPaket)' == ''">false</_ConfigContainsPaket> |
Comment on lines
+1
to
+20
| { | ||
| "version": 1, | ||
| "isRoot": true, | ||
| "tools": { | ||
| "paket": { | ||
| "version": "10.3.1", | ||
| "commands": [ | ||
| "paket" | ||
| ], | ||
| "rollForward": false | ||
| }, | ||
| "fake-cli": { | ||
| "version": "6.1.4", | ||
| "commands": [ | ||
| "fake" | ||
| ], | ||
| "rollForward": false | ||
| } | ||
| } | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.