Skip to content

Comments

chore(Deps): Update SDK to v10#279

Merged
bartelink merged 10 commits intofsprojects:masterfrom
webwarrior-ws:dotnet8-squashed
Jan 23, 2026
Merged

chore(Deps): Update SDK to v10#279
bartelink merged 10 commits intofsprojects:masterfrom
webwarrior-ws:dotnet8-squashed

Conversation

@webwarrior-ws
Copy link
Contributor

Because .NETv6 is already EOS.

Build was failing with
```
Unsupported log file format. Latest supported version is 16, the log file has version 21.
```

Fixed by using a workaround described in [1].

[1] fsprojects/FAKE#2748
In Argu.Samples.LS project to get rid of compile warnings.
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable on my end.
Would you like a release after this PR?

@nojaf nojaf requested a review from bartelink January 22, 2026 09:32
@eiriktsarpalis
Copy link
Member

Why not just move to .NET 10 directly?

@bartelink
Copy link
Member

bartelink commented Jan 22, 2026

Might as well also incorporate the 3x dependabot diffs for the action version bumps [and roll to .NET 10 as Eirik says]

knocte and others added 5 commits January 22, 2026 18:54
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Closes fsprojects#276

Signed-off-by: dependabot[bot] <support@github.com>
Instead of hardcoding the .NET version number.
@knocte
Copy link
Contributor

knocte commented Jan 23, 2026

Hey,

With @webwarrior-ws's permission, I've finished this PR, addressing the feedback:

Do we still need this? Doesn't it read the global.json version if present?

Changed it to use with: global-json-file to not need to update version number in two places each time .NET is upgraded.

Why not just move to .NET 10 directly?

Added a commit to use .NET10 instead of .NET8.

Might as well also incorporate the 3x dependabot diffs

Done, cherry-picked those commits into this PR.

@bartelink bartelink changed the title Migrate from .NETv6 to .NETv8 Update to SDK v10 Jan 23, 2026
@bartelink
Copy link
Member

Thanks, let me know if you have any stragglers before we merge

@bartelink bartelink changed the title Update to SDK v10 chore(Deps): Update SDK to v10 Jan 23, 2026
@bartelink bartelink merged commit cd01076 into fsprojects:master Jan 23, 2026
4 checks passed
@knocte
Copy link
Contributor

knocte commented Jan 23, 2026

Thanks.

I had added "Closes #XYZ" statements to dependabot's commit msgs so that those PRs got closed when merging, but you guys chose to squash all commits when merging, so that didn't happen. Then those dependabot's PRs need to be closed manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants