Skip to content

certificate as binary #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MinalSoni wants to merge 1 commit into
base: master
Choose a base branch
from
Open

certificate as binary #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/passbook/signer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,13 @@ def compute_cert
@key_hash[:key] = OpenSSL::PKey::RSA.new File.read(key), password
@key_hash[:cert] = OpenSSL::X509::Certificate.new File.read(certificate)
else
p12 = OpenSSL::PKCS12.new File.read(certificate), password
p12 = OpenSSL::PKCS12.new certificate_data, password
@key_hash[:key], @key_hash[:cert] = p12.key, p12.certificate
end
end

def certificate_data
certificate.is_a?(Pathname) ? File.read(certificate) : certificate
end
end
end
33 changes: 26 additions & 7 deletions spec/lib/passbook/signer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
OpenSSL::X509::Certificate.should_receive(:new).with('my_p12_certificate_file').and_return 'my_ssl_p12_cert'
end

subject {Passbook::Signer.new(certificate: 'my_p12_certificate', password: 'password',
subject {Passbook::Signer.new(certificate: 'my_p12_certificate', password: 'password',
key: 'my_p12_key', wwdc_cert: 'i_love_robots').key_hash}
its([:key]) {should eq 'my_rsa_key'}
its([:cert]) {should eq 'my_ssl_p12_cert'}
Expand All @@ -44,16 +44,17 @@
context 'p12 files' do
let (:p12) { double('OpenSSL::PKCS12') }
let (:final_hash) {{:key => 'my_final_p12_key', :cert => 'my_final_p12_cert'}}
let (:cert_path) { Pathname.new('./my_p12_cert')}
context 'using config file certificates' do
before do
p12.should_receive(:key).and_return final_hash[:key]
p12.should_receive(:certificate).and_return final_hash[:cert]
Passbook.should_receive(:p12_password).and_return 'password'
Passbook.should_receive(:wwdc_cert).and_return 'i_love_robots'
Passbook.should_receive(:p12_certificate).and_return 'my_p12_cert'
Passbook.should_receive(:p12_certificate).and_return cert_path
Passbook.should_receive(:p12_key).and_return nil
File.should_receive(:read).with('my_p12_cert').and_return 'my_p12_cert_file'
OpenSSL::PKCS12.should_receive(:new).with('my_p12_cert_file', 'password').and_return p12
File.should_receive(:read).with(cert_path).and_return 'my_p12_certificate_file'
OpenSSL::PKCS12.should_receive(:new).with('my_p12_certificate_file', 'password').and_return p12
end

subject {Passbook::Signer.new.key_hash}
Expand All @@ -69,11 +70,29 @@
Passbook.should_receive(:p12_key).never
Passbook.should_receive(:p12_certificate).never
Passbook.should_receive(:wwdc_cert).never
File.should_receive(:read).with('my_p12_cert').and_return 'my_p12_cert_file'
OpenSSL::PKCS12.should_receive(:new).with('my_p12_cert_file', 'password').and_return p12
File.should_receive(:read).with(cert_path).and_return 'my_p12_certificate_file'
OpenSSL::PKCS12.should_receive(:new).with('my_p12_certificate_file', 'password').and_return p12
end

subject {Passbook::Signer.new(certificate: 'my_p12_cert', password: 'password',
subject {Passbook::Signer.new(certificate: cert_path, password: 'password',
wwdc_cert: 'i_love_robots').key_hash}
its([:key]) {should eq final_hash[:key]}
its([:cert]) {should eq final_hash[:cert]}
end

context 'using passed in certificates as binary' do
before do
p12.should_receive(:key).and_return final_hash[:key]
p12.should_receive(:certificate).and_return final_hash[:cert]
Passbook.should_receive(:p12_password).never
Passbook.should_receive(:p12_key).never
Passbook.should_receive(:p12_certificate).never
Passbook.should_receive(:wwdc_cert).never
File.should_receive(:read).with(cert_path).and_return 'my_p12_certificate_file'
OpenSSL::PKCS12.should_receive(:new).with('my_p12_certificate_file', 'password').and_return p12
end

subject {Passbook::Signer.new(certificate: File.read(cert_path), password: 'password',
wwdc_cert: 'i_love_robots').key_hash}
its([:key]) {should eq final_hash[:key]}
its([:cert]) {should eq final_hash[:cert]}
Expand Down