Per camera snooze by austinc3030 · Pull Request #1135 · fronzbot/blinkpy

austinc3030 · 2025-10-27T18:27:36Z

Description:

Related Issue: #955

This PR adds support for snoozing cameras.

Been running this for over a year with no issues snoozing cameras. While not "scientifically" tested, my script using this PR continues to arm/disarm, as well as take snapshots.

Could use some help with tox tests.

Related issue (if applicable): fixes #

Checklist:

Local tests with tox run successfully PR cannot be meged unless tests pass
Changes tested locally to ensure platform still works as intended
Tests added to verify new code works

austinc3030 · 2025-10-27T18:28:14Z

Sorry but I am working on another feature and needed to move my Camera Snooze commits to a new branch.

fronzbot · 2025-10-28T18:59:56Z

@austinc3030 sounds good. I didn't review the other PR because you had it marked as WIP so I assumed you were still working on it. I'll review this when I have some time (hopefully this week).

blinkpy/api.py

fronzbot · 2025-10-28T20:15:06Z

blinkpy/camera.py

+        if res is None:
+            return None
+        return res.get("camera", [{}])[0].get("snooze_till")


There's no indication to the user if this fails. I think a better approach would be to either let it raise an exception OR catch the exception and log an error/warning. I tend to favor the latter, but could be convinced either way.

Suggested change

if res is None:

return None

return res.get("camera", [{}])[0].get("snooze_till")

try:

return res["camera"][0]["snooze_till"]

except TypeError:

return None

except (IndexError, KeyError) as e:

_LOGGER.warning("Exception %s: Encountered a likely malformed response from the snooze API endpoint. Response: %s", e, res)

Addressed in 050dca6

blinkpy/camera.py

fronzbot · 2025-10-28T20:27:31Z

blinkpy/sync_module.py

 import logging
 import string
 import datetime
+from json import dumps


Remove this. sync_module.py already has access to this through the json_dumps method in blinkpy.helpers.util

Suggested change

from json import dumps

Addressed in 8009230

fronzbot · 2025-10-28T20:28:27Z

blinkpy/sync_module.py

+
+    async def async_snooze(self, snooze_time=240):
+        """Set sync snooze status."""
+        data = dumps({"snooze_time": snooze_time})


Suggested change

data = dumps({"snooze_time": snooze_time})

data = json_dumps({"snooze_time": snooze_time})

Addressed in 8009230

fronzbot · 2025-10-28T20:37:34Z

tests/test_camera_functions.py

+            return_value=mock_resp,
+        ):
+            result = await self.camera.snooze_till
+            self.assertEqual(result, {"camera": [{"snooze_till": 1234567890}]})


The self.camera.snooze_till method returns the snooze_till value, not the full dictionary (based on your implementation. I don't know what your intent was, but this makes sense to me).

So this should be the following, assuming it was your code intent:

Suggested change

self.assertEqual(result, {"camera": [{"snooze_till": 1234567890}]})

self.assertEqual(result, 1234567890)

This test was removed. Will be adding new tests.

fronzbot · 2025-10-28T20:39:49Z

tests/test_camera_functions.py

+        with mock.patch("blinkpy.api.request_camera_snooze", return_value=mock_resp):
+            response = await self.camera.async_snooze()
+            self.assertEqual(response, {})
+        mock_resp = mresp.MockResponse({}, 200)


This is failing and I think it's related to my confusion earlier. I believe the BlinkCamera.async_snooze method is supposed to grab the json data (like you do in the Doorbell class). If that's true and works to fix this, then you don't need to overload the async_snooze method in the Doorbell class since both functions will be identical.

This test was removed and new tests will be added.

fronzbot · 2025-10-28T20:42:20Z

tests/test_sync_module.py

 """Tests camera and system functions."""

 import datetime
+from json import dumps


Suggested change

from json import dumps

from blinkpy.helpers.util import json_dumps

fronzbot · 2025-10-28T20:42:47Z

tests/test_sync_module.py

+            mock_resp_local.return_value.status = 200
+            mock_resp_local.return_value.json.return_value = {"status": 200}
+            snooze_time = 240
+            expected_data = dumps({"snooze_time": snooze_time})


Suggested change

expected_data = dumps({"snooze_time": snooze_time})

expected_data = json_dumps({"snooze_time": snooze_time})

fronzbot · 2025-10-28T20:44:27Z

blinkpy/camera.py

+            return None
+        return res.get("camera", [{}])[0].get("snooze_till")
+
+    async def async_snooze(self, snooze_time=240):


what are the units of snooze_time? Please annotate this in the docstring. It looks like these are in seconds?

Addressed in a7aa35d

Snooze time is in minutes.

Actually, snooze time used to be minutes (hence the 240 value, 4 hours). However, it now looks like snooze time is in seconds (240 = 4 minutes). This appears to be a change to how blink's API is handling the value.

fronzbot · 2026-01-04T21:58:55Z

@austinc3030 are you still working on this PR? I reviewed it a few months back with no response.

austinc3030 · 2026-01-06T17:11:19Z

Hey, @fronzbot.

You know how it goes: life got busy around the holidays and I completely forgot to circle back to this.

I will try to pick this up this week. Thanks for the ping.

austinc3030 · 2026-01-06T17:12:26Z

I don't recall the current state of this but last I remember, camera snooze worked for all cameras except I am hitting an issue with my new Blink Arc cameras. They don't snooze with the current implementation. I was working on a fix for this along side this PR. I will review and update.

austinc3030 · 2026-02-09T20:09:33Z

Converted to draft while I work on this. Should be ready this week. Will add a new comment when ready. Thank you for your patience.

Co-authored-by: Kevin Fronczak <kfronczak@gmail.com>

This reverts commit 6f50411.

…I change.

austinc3030 · 2026-02-10T18:33:47Z

@fronzbot I believe we are in a good state now and ready for re-review. Thanks!

austinc3030 and others added 7 commits October 13, 2025 14:11

Add Per Camera Snooze Functionality

90a1a58

Merge remote-tracking branch 'upstream/dev' into dev

a002e90

Merge branch 'fronzbot:dev' into dev

2d649f6

Merge branch 'fronzbot:dev' into dev

50cc35e

Merge remote-tracking branch 'upstream/dev' into dev

267909f

Merge remote-tracking branch 'upstream/dev' into dev

5554686

Merge remote-tracking branch 'upstream/dev' into dev

85d7c66

fronzbot requested changes Oct 28, 2025

View reviewed changes

Merge branch 'dev' into per_camera_snooze

456d0f2

Repository owner deleted a comment from jmgarcia1230-commits Jan 6, 2026

austinc3030 added 2 commits February 9, 2026 13:49

Merge branch 'fronzbot:dev' into per_camera_snooze

ad37ae5

Support for 'hawk' (Blink Arc) cameras

1e1f9a8

austinc3030 marked this pull request as draft February 9, 2026 20:08

austinc3030 and others added 8 commits February 9, 2026 20:12

Remove inaccurate tests. Will re-add

f327a1c

Remove json import and use json_dumps

8009230

Document snooze time parameter

a7aa35d

Apply PR Suggestion

ab23853

Co-authored-by: Kevin Fronczak <kfronczak@gmail.com>

Apply PR Suggestion

35455d6

Co-authored-by: Kevin Fronczak <kfronczak@gmail.com>

Log an error when snooze fails for a camera.

e891da6

PR feedback and improvement to try/catch structure.

f12a23a

Fix tests before adding new tests

1715a8b

austinc3030 force-pushed the per_camera_snooze branch from e9ec96c to 1715a8b Compare February 10, 2026 16:00

austinc3030 added 2 commits February 10, 2026 16:03

Add creds.json and test.py to gitignore

6f50411

Revert "Add creds.json and test.py to gitignore"

52a7725

This reverts commit 6f50411.

austinc3030 added 4 commits February 10, 2026 17:30

blinkpy api changes to better work with blink api

725dbbf

Add new tests

686d8c5

Note that snooze time is in seconds, not minutes. This was a blink AP…

800743c

…I change.

Fix tests.

8bad169

austinc3030 marked this pull request as ready for review February 10, 2026 18:32

austinc3030 requested a review from fronzbot February 10, 2026 18:33

	data = dumps({"snooze_time": snooze_time})
	data = json_dumps({"snooze_time": snooze_time})

	self.assertEqual(result, {"camera": [{"snooze_till": 1234567890}]})
	self.assertEqual(result, 1234567890)

	from json import dumps
	from blinkpy.helpers.util import json_dumps

	expected_data = dumps({"snooze_time": snooze_time})
	expected_data = json_dumps({"snooze_time": snooze_time})

Conversation

austinc3030 commented Oct 27, 2025

Description:

Checklist:

Uh oh!

austinc3030 commented Oct 27, 2025

Uh oh!

fronzbot commented Oct 28, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fronzbot commented Jan 4, 2026

Uh oh!

austinc3030 commented Jan 6, 2026

Uh oh!

austinc3030 commented Jan 6, 2026

Uh oh!

austinc3030 commented Feb 9, 2026

Uh oh!

austinc3030 commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants