Merged
Conversation
wuweiweiwu
approved these changes
Dec 3, 2018
Member
wuweiweiwu
left a comment
wuweiweiwu
left a comment
There was a problem hiding this comment.
Looks good.
Can you also look into getting this patch into scroll zone? or we can fork it under front end collective and publish our own
Collaborator
Author
|
I raised PR azuqua/react-dnd-scrollzone#40 I think this patch is sufficient for now, but would consider maintaining fork of react-dnd-scrollzone under frond end collective if there would be needed more changes. You can also consider enabling https://renovatebot.com/ for maintaining up to date dependencies. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wuweiweiwu Patching
react-dnd-scrollzoneis probably better than using fork