Skip to content

fix: remove max height from expandable section #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dedarritchon merged 1 commit into from
Oct 30, 2025
Merged

fix: remove max height from expandable section #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,15 @@

## [0.20.0](https://github.com/frontapp/front-ui-kit/compare/v0.19.0...v0.20.0) (2025-10-29)


### Features

* navigation dropdown ([#273](https://github.com/frontapp/front-ui-kit/issues/273)) ([3774b61](https://github.com/frontapp/front-ui-kit/commit/3774b6134c1797106b68b74d97f9aeb0be827a0f))
- navigation dropdown ([#273](https://github.com/frontapp/front-ui-kit/issues/273)) ([3774b61](https://github.com/frontapp/front-ui-kit/commit/3774b6134c1797106b68b74d97f9aeb0be827a0f))

## [0.19.0](https://github.com/frontapp/front-ui-kit/compare/v0.18.1...v0.19.0) (2025-10-24)


### Features

* empty state subtitle ([#298](https://github.com/frontapp/front-ui-kit/issues/298)) ([7c11bf4](https://github.com/frontapp/front-ui-kit/commit/7c11bf4510838df83d7367321fc3b2ed301fa382))
- empty state subtitle ([#298](https://github.com/frontapp/front-ui-kit/issues/298)) ([7c11bf4](https://github.com/frontapp/front-ui-kit/commit/7c11bf4510838df83d7367321fc3b2ed301fa382))

## [0.18.1](https://github.com/frontapp/front-ui-kit/compare/v0.18.0...v0.18.1) (2025-10-24)

Expand Down
9 changes: 3 additions & 6 deletions src/components/expandableSection/expandableSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ interface ExpandableSectionProps {
showBorder?: boolean;
/** Whether to show the border between header and content when expanded (default: true) */
showContentBorder?: boolean;
/** Maximum height when expanded (default: 1000px) */
maxHeight?: string;
/** Background color for the expandable section (default: greys.white) */
backgroundColor?: string;
/** Whether actions should only be visible on hover (default: false - actions always visible). */
Expand Down Expand Up @@ -125,10 +123,10 @@ const StyledActionsDiv = styled.div<{$showOnHover?: boolean}>`
}`}
`;

const StyledContentDiv = styled.div<{isOpen: boolean; showContentBorder?: boolean; maxHeight?: string}>`
const StyledContentDiv = styled.div<{isOpen: boolean; showContentBorder?: boolean}>`
border-top: ${({showContentBorder = true}) => (showContentBorder ? `1px solid ${greys.shade20}` : 'none')};
overflow: hidden;
max-height: ${({isOpen, maxHeight = '1000px'}) => (isOpen ? maxHeight : '0')};
max-height: ${({isOpen}) => (isOpen ? 'unset' : '0')};
opacity: ${({isOpen}) => (isOpen ? '1' : '0')};
`;

Expand All @@ -149,7 +147,6 @@ export const ExpandableSection: FC<ExpandableSectionProps> = (props) => {
hoverBackgroundColor,
showBorder = true,
showContentBorder = true,
maxHeight = '1000px',
backgroundColor,
showActionsOnHover = false,
groupActions = false
Expand Down Expand Up @@ -239,7 +236,7 @@ export const ExpandableSection: FC<ExpandableSectionProps> = (props) => {
</StyledTitleContainerDiv>
{renderActions()}
</StyledHeaderDiv>
<StyledContentDiv isOpen={isOpen} showContentBorder={showContentBorder} maxHeight={maxHeight}>
<StyledContentDiv isOpen={isOpen} showContentBorder={showContentBorder}>
{children}
</StyledContentDiv>
</StyledExpandableSectionDiv>
Expand Down
Loading