Skip to content

fix: dropdown border color #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dedarritchon merged 5 commits into from
Oct 22, 2025
Merged

fix: dropdown border color #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d18ead0
ExpandableSection tewaks
dedarritchon Oct 17, 2025
fcd4e5a
Merge branch 'main' of github.com:frontapp/front-ui-kit
dedarritchon Oct 20, 2025
27a8638
Merge branch 'main' of github.com:frontapp/front-ui-kit
dedarritchon Oct 21, 2025
8ce3b14
Merge branch 'main' of github.com:frontapp/front-ui-kit
dedarritchon Oct 22, 2025
1fa20a4
using color-semantic/border/tertiary for dropdown border color
dedarritchon Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@

## [0.17.0](https://github.com/frontapp/front-ui-kit/compare/v0.16.1...v0.17.0) (2025-10-22)


### Features

* large plus icon ([#291](https://github.com/frontapp/front-ui-kit/issues/291)) ([cdf4ce3](https://github.com/frontapp/front-ui-kit/commit/cdf4ce381448bedff2d3cece4f1e91b9c8626b7a))
- large plus icon ([#291](https://github.com/frontapp/front-ui-kit/issues/291)) ([cdf4ce3](https://github.com/frontapp/front-ui-kit/commit/cdf4ce381448bedff2d3cece4f1e91b9c8626b7a))

## [0.16.1](https://github.com/frontapp/front-ui-kit/compare/v0.16.0...v0.16.1) (2025-10-21)

Expand Down
2 changes: 1 addition & 1 deletion src/elements/dropdown/dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
border-radius: 8px;
background: white;
box-shadow: rgba(99, 99, 99, 0.2) 0px 2px 8px 0px;
border: 1px solid ${greys.shade40};
border: 1px solid ${greys.shade20};
width: 100%;
overflow: auto;
${(p) => css`
Expand Down Expand Up @@ -170,7 +170,7 @@
() =>
React.Children.toArray(children).some((child) => {
if (!isValidElement(child) || !child.props) return false;
const childProps = child.props as Record<string, unknown>;

Check warning on line 173 in src/elements/dropdown/dropdown.tsx

View workflow job for this annotation

GitHub Actions / lint 

Do not use any type assertions
return 'submenu' in childProps && Boolean(childProps.submenu);
}),
[children]
Expand Down
Loading