Skip to content

Use reactphp/async instead of clue/reactphp-block#163

Merged
WyriHaximus merged 1 commit intofriends-of-reactphp:0.6.xfrom
dinooo13:async
Oct 29, 2022
Merged

Use reactphp/async instead of clue/reactphp-block#163
WyriHaximus merged 1 commit intofriends-of-reactphp:0.6.xfrom
dinooo13:async

Conversation

@dinooo13
Copy link
Copy Markdown
Contributor

@dinooo13 dinooo13 commented Sep 30, 2022 •
edited
Loading

@dinooo13 dinooo13 marked this pull request as draft October 1, 2022 00:04
@dinooo13
Copy link
Copy Markdown
Contributor Author

dinooo13 commented Oct 1, 2022

Still need to test this, no mysql:5 on arm.

@dinooo13
Copy link
Copy Markdown
Contributor Author

dinooo13 commented Oct 3, 2022

Locally with PHP 8.1 this works fine for me. Can we restart the checks? Some weird failing there with 8.1, 8, 7.3 and HHVM green and only 7.1 failing.

@dinooo13 dinooo13 marked this pull request as ready for review October 3, 2022 16:45
SimonFrings
SimonFrings reviewed Oct 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinooo13 thanks for bringing this up 👍

One little thing below, can you also add some references in your PR description similar to my comment in clue/reactphp-mq#34.

Comment thread tests/BaseTestCase.php Outdated
@dinooo13
Copy link
Copy Markdown
Contributor Author

dinooo13 commented Oct 4, 2022

Resolved, thanks for the review 👍🏼

@dinooo13
Copy link
Copy Markdown
Contributor Author

dinooo13 commented Oct 4, 2022 •
edited
Loading

I think something is a bit flaky in the tests on the ci, should we maybe open an issue further investigating this?

SimonFrings
SimonFrings approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something is a bit flaky in the tests on the ci, should we maybe open an issue further investigating this?

@clue restarted the failed tests, seems like there's been a hickup in one of them. From my end this PR seems fine as it is right now 👍

@clue clue added this to the v0.6.0 milestone Oct 17, 2022
clue
clue approved these changes Oct 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinooo13 Thank you for looking into this, changes LGTM! 👍 Happy to get this shipped with the next major as per #164, keep it up!

@WyriHaximus WyriHaximus merged commit 89067b2 into friends-of-reactphp:0.6.x Oct 29, 2022
@dinooo13 dinooo13 deleted the async branch October 29, 2022 18:16
@clue clue mentioned this pull request Feb 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

@SimonFrings SimonFrings SimonFrings approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v0.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dinooo13 @WyriHaximus @clue @SimonFrings