Move agent-playground → apps/studio-ui#293
Open
ljagiello wants to merge 6 commits into
Open
Conversation
Renames the SvelteKit web UI from `tools/agent-playground` to `apps/studio-ui` and its runtime identifiers from `playground` to `studio-ui`. The package is now `@atlas/studio-ui`, the dev task is `deno task studio-ui` (orchestrated by `dev:studio-ui`), the compiled binary is `bin/studio-ui`, env vars are `STUDIO_UI_PORT`/`STUDIO_UI_HOST` / `FRIDAY_PORT_STUDIO_UI`, and the log prefix is `[studio-ui]`. Launcher (Go), installer (Rust + Svelte), Dockerfile, GH Actions workflow, build/dev scripts, atlas-cli `agent exec`, docs, and skill markdown all updated in lockstep. Internal names left intact per design: the `"playground"` workspaceId magic string, `PlaygroundContextAdapter` class, internal "the playground" comments, TanStack query keys, and QA scenario locals. Verified: `deno task typecheck`, `biome check`, `deno lint`, `npm run build` (vite), `deno compile` (binary boots with [studio-ui] log prefix on :5200), `go build ./...`, `go test ./...` (friday-launcher), `cargo check --tests` (studio-installer).
The previous commit captured the file moves and config rewrites but missed the source edits I'd made after `git mv` — they were in the working tree but never `git add`ed. This commit lands the rest of the rename: studio-installer Rust/Svelte source (Tauri command playground_url → studio_ui_url, serde field, constants), the Go launcher's playgroundURL → studioUIURL, atlas-cli `agent exec` user-facing strings, docs (README, CONTRIBUTING, NOTICE, THIRD_PARTY_LICENSES, skill markdown), Dockerfile, run-platform.sh, dev-watcher, build-studio, and the critical bin/playground → bin/studio-ui in .github/workflows/studio-build.yml that the codesign step iterates over.
Svelte derives its CSS scope hash from the component's source path. Moving `tools/agent-playground` → `apps/studio-ui` changed every `.svelte` component's scope hash, which only surfaced for components with snapshot-based tests. validation-pill-row is the only one in the repo with a `toMatchSnapshot` on rendered HTML; its 5 snapshots needed regenerating against the new path. The remaining 5979 tests pass without changes.
After the agent-playground → studio-ui rename, the launcher reads FRIDAY_PORT_STUDIO_UI for the port override. Existing installs have FRIDAY_PORT_PLAYGROUND written to ~/.friday/local/.env (by the installer at 15200, or by users at custom values for multi-instance setups). Without a migration, customised ports silently revert to the default on upgrade. This migration rewrites the legacy key on first daemon boot: - .env missing → no-op - only PLAYGROUND → rewrite to STUDIO_UI, value preserved - only STUDIO_UI → no-op - both → drop legacy line (new key wins at the launcher) Idempotent via the standard JetStream migration ledger. Line-by-line rewrite preserves comments, blank lines, and all unrelated keys. Tests cover all 4 branches + quoted values, surrounding context preservation, comment-key disambiguation, and second-pass idempotency.
Extends the migration to defensively rewrite all three renamed env vars: FRIDAY_PORT_PLAYGROUND → FRIDAY_PORT_STUDIO_UI PLAYGROUND_PORT → STUDIO_UI_PORT PLAYGROUND_HOST → STUDIO_UI_HOST The launcher normally injects PLAYGROUND_PORT/HOST into the spawned binary's process env at boot, so they don't usually live on disk — but a user could have set them in ~/.friday/local/.env for debugging or a custom dev setup. Better to migrate them and be wrong than skip them and have a user silently lose their override. Each pair is applied independently: a file with FRIDAY_PORT_PLAYGROUND set but no PLAYGROUND_PORT only sees the first key rewritten. Tests cover each pair in isolation, the multi-pair case, and the selective case where only some legacy keys are present.
Real bug: the installer runs `ensure_platform_env_vars` BEFORE `migrate` (per apps/studio-installer/src/steps/Extract.svelte). On upgrade, the installer seeds FRIDAY_PORT_STUDIO_UI=15200 (default) into the .env because the key is missing, then migrate sees both legacy + new and the old "drop legacy" branch silently lost any custom value the user had set on FRIDAY_PORT_PLAYGROUND. Fix: when both keys are present, the LEGACY value wins. Drop the new-key line (just an installer default), rewrite the legacy line to use the new key name. User customisations now survive the upgrade. Behaviour applies uniformly to all three pairs. FRIDAY_PORT_* is the installer-managed case where this matters most; PLAYGROUND_PORT/HOST follow the same rule for consistency (and "user set the legacy explicitly, then also added the new key" almost certainly means they wanted the legacy value preserved). Tests updated: the both-present branch now asserts the legacy value survives, with an additional test that confirms line ordering is preserved when the new-key line is removed from elsewhere in the file.
Contributor
|
Two pre-existing footguns this rename surfaces — not blocking this PR, but worth a follow-up: 1. sessionContext: { id: sessionId, workspaceId: workspaceId ?? "playground" },When callers omit 2. formData.set("workspaceId", "playground");The daemon's upload route ( Both share the same root cause ( |
Collaborator
|
Targeted for |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the SvelteKit web UI from
tools/agent-playgroundtoapps/studio-uiand its runtime identifiers fromplaygroundtostudio-ui.@atlas/agent-playground→@atlas/studio-uideno task playground→deno task studio-ui;dev:playground[:stable]→dev:studio-ui[:stable]playground→studio-ui; envPLAYGROUND_PORT/HOST→STUDIO_UI_PORT/HOST;FRIDAY_PORT_PLAYGROUND→FRIDAY_PORT_STUDIO_UI; log prefix[playground]→[studio-ui]playgroundURL→studioUIURL+ 4 test filesplayground_url→studio_ui_url; serde fieldplayground_healthy→studio_ui_healthy; constants, store, helpersdocker/run-platform.sh,studio-build.yml(incl. criticalbin/playground→bin/studio-uiin codesigning loop),scripts/build-studio.ts,scripts/dev-watcher.ts,.vscode/settings.jsonREADME.md,CONTRIBUTING.md,NOTICE,THIRD_PARTY_LICENSES.md, skill markdownagent execerror messages +DEFAULT_PLAYGROUND_URL→DEFAULT_STUDIO_UI_URLLeft intact (internal identifiers, semantically distinct from binary/service name):
"playground"workspaceId magic stringPlaygroundContextAdapterclass +PlaygroundContextOptsinterfaceTest plan
deno installdeno task sync:sveltedeno task typecheck— 0 errorsdeno run -A npm:@biomejs/biome check— 0 errorsdeno lintnpm run buildinapps/studio-ui— vite build succeedsdeno compileofapps/studio-ui/static-server.ts— produces working binary; boots with[studio-ui]log prefix on :5200go build ./...go test ./...intools/friday-launchercargo check --testsinapps/studio-installer/src-tauribin/studio-ui)