This repository was archived by the owner on Apr 9, 2021. It is now read-only.
Playlist command#599
Open
kthezelais wants to merge 2 commits intofreyacodes:devfrom
TiltdBastion:playlistCommand
Open
Playlist command#599kthezelais wants to merge 2 commits intofreyacodes:devfrom TiltdBastion:playlistCommand
kthezelais wants to merge 2 commits intofreyacodes:devfrom
TiltdBastion:playlistCommand
Conversation
|
Killian THEZELAIS seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
freyacodes
suggested changes
Dec 9, 2019
|
|
||
| public class PlayListCommand extends JCommand implements IMusicCommand, ICommandRestricted { | ||
|
|
||
| private List<AudioTrackContext> playlist; |
Owner
There was a problem hiding this comment.
This fundamentally doesn't work. You're sharing the same playlist between everyone. It also doesn't persist between restarts.
Doing something like this this the right way would require working with the database, and even then I would do things differently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add a playlist command. This feature is used to store tracks into a parallel list of the queue, and this list of tracks can be run on the queue when the user use the command ;;playlist run.
You can find some details on how to use this new command below :
The command ;;playlist Allows you to configure the playlist: