Conversation
Yes it HAS to be in a different module
Restarts the application after receiving classpath change commands
…lassLoader We don't really need full snapshots as we recreate a new ClassLoader on each restart, which always reloads the classes, see the notes
Required for Java 24 support
So we can run it when an instance is incompatible
… for ClassDesc(s)
Also add `@DynamicCall` marker on methods used by codegen
Fixes build() being matched with an unrelated no-arg method
Will allow to use this even with Spring Dev Tools
Built in ClassGraph
…thWatcher As a lighter alternative, since we don't need the updated data
Fixes issues where an old instance would be used on shutdown
…tdown() It previously called JDABuilderSession#onShutdown more than once
To avoid duplicate names in the same package
Call the full code when shutting down JDA, or call the passed closure when reusing JDA The closure allows to shut down the pools after the events were fired
…eduleShutdownSignal As we don't have it when it is triggered by JDA's shutdown hook
…ported values Not actually useful at this moment, but still
- Make a ClassTransformer using context parameters - Add MethodModel#toFullyQualifiedString - Add MethodModel#matches(name, signature) - Add ClassModel#findMethod(name, signature) - Add Int#withVisibility(AccessFlag?) - Use constants for transformation/move targets - Make sure the targets are present before transforming - Log transformations with what they do - Rename classes to what they do
…eRestartException
As they aren't handled by URLClassLoader and will thus call the AppClassLoader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 (see freya022/BotCommands#232)