fix: append nonce alongside unsafe-inline instead of replacing it#3842
Open
SisyphusZheng wants to merge 4 commits into
Open
fix: append nonce alongside unsafe-inline instead of replacing it#3842SisyphusZheng wants to merge 4 commits into
SisyphusZheng wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When useNonce: true, the CSP middleware replaces 'unsafe-inline' with 'nonce-{value}' using
eplaceAll():
script-src 'self' 'nonce-deadbeef42'This prevents users from keeping 'unsafe-inline' as a fallback for older browsers that don't support CSP Level 3 nonces — a pattern recommended by web.dev and modern CSP guides. Users who need both Fresh's nonce-based inline scripts AND a browser fallback cannot achieve this.
Per discussion in #3813, the fix is simpler than adding a new option: stop stripping 'unsafe-inline' and instead append the nonce alongside it.
Solution
Change
eplaceAll →
eplace, so the nonce is appended while 'unsafe-inline' stays:
script-src 'self' 'unsafe-inline' 'nonce-deadbeef42'Users who want only the nonce simply omit 'unsafe-inline' from their CSP directives. Users who want the fallback keep it. No new API surface needed.
Changes
eplaceAll("'unsafe-inline'", 'nonce-') →
eplace("'unsafe-inline'", 'unsafe-inline' 'nonce-')
Verification
deno test -A packages/fresh/src/middlewares/csp_test.tsx — 12 passed, 0 failed