-
Notifications
You must be signed in to change notification settings - Fork 24
added ics schemas to genesis #2662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| } | ||
|
|
||
| // not used yet | ||
| pub struct TestRewardsProvider {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not used
| /// Storage for keeping a ledger of staked token amounts for accounts. | ||
| /// - Keys: AccountId | ||
| /// - Value: [`StakingDetails`](types::StakingDetails) | ||
| /// - Value: [`StakingDetails`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated due to 1.90 required linting guidelines
| }; | ||
|
|
||
| if !messages_remain || cursor.3 % <u64>::from(T::MigrateEmitEvery::get()) == 0 { | ||
| if !messages_remain || cursor.3.is_multiple_of(<u64>::from(T::MigrateEmitEvery::get())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, didn't know about is_multiple_of👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a packaging script? I don't think we publish or deploy this anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a useful tool; might be worth separating the intent/schema data out to a separate resource file so that the tool itself can be used to upload any future schemas without code modification.
JoeCap08055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great--one comment:
In the past, we've explicitly mirrored the SchemaIds from Mainnet onto Testnet by setting storage directly; then we set the max_schema_id on Testnet to 16000 so that any new schemas created won't interfere with the numeric ID space mirrored from Mainnet.
Do we want to continue this practice?
Or--since that practice was conceived before we had name resolution on-chain--do we no longer need it? Is there any advantage any longer to maintaining numeric ID parity between Testnet and Mainnet?
Goal
The goal of this PR is
Related to #https://github.com/ProjectLibertyLabs/interoperable-context-service/issues/42
Discussion
Example run
Checklist