forked from ModelSEED/ModelSEEDpy
-
Notifications
You must be signed in to change notification settings - Fork 4
pulling Chris' code to resolve errors #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
freiburgermsu
wants to merge
86
commits into
freiburgermsu:main
Choose a base branch
from
cshenry:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix RAST parsing
bumped to version 0.4.0
Sync local dev branch with upstream changes Merging latest updates from upstream/dev to keep our fork in sync with the main repository. This brings in the latest features and bug fixes from the original project.
msatpcorrection.py default path + reactions pathways
…e, setting failure testing to false, and fixing report
changes in MSTemplate file to add additional biomass categories
…omes; fixing msexpression
gbff support
mstemplate biomass
# Conflicts: # modelseedpy/core/msatpcorrection.py # modelseedpy/core/msmodel.py # modelseedpy/core/mstemplate.py # setup.py
…simulation, biochemistry, and gapfilling
- Implements expression-constrained flux balance analysis - Handles genome-to-model and type transformations automatically - Integrates with ExpressionActivationPkg for optimization - Includes comprehensive NumPy-style docstring with examples - Adds 12 unit tests covering all functionality and edge cases - Validates thresholds, conditions, and model compatibility - Related to PRD 0001 and task list tasks-0001
…hat lack all dependencies
Fixed issue where reaction expression values were blank when converting from gene-level to reaction-level expression. The problem occurred when expression data was loaded without a genome or when model gene IDs didn't match genome feature IDs. The original code only searched through the genome object, failing to find genes with different ID formats (e.g., model has ACIAD#### but expression has ACIAD_RS#####). Changes: - First attempt direct lookup in self.features by gene ID - Fall back to genome search (which supports aliases) if direct lookup fails - This allows matching when gene IDs are identical, even without a genome - Maintains backward compatibility with genome-based alias resolution Fixes blank reaction expression values in genome-to-model conversion. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Integrates a new method to average expression data across replicates for each strain. This method: - Takes replicate columns (e.g., ACN2586_1, ACN2586_2) and averages them into single columns per strain - Properly uses MSCondition class instead of a fake ExpressionCondition - Returns a new MSExpression object with averaged data - Handles cases where replicates exist, single columns exist, or no data is found - Includes comprehensive logging and error handling This method is useful for preprocessing expression data before analysis.
…011CUoKZ7YGo72duYdrs7oTT Add average_expression_replicates method to MSExpression
…ance of claude web
…fixes to community and flexible biomass and thermo and adding features to msexpression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors from phenotype simulating in the ASV Modeling Notebook made me realize that I may have an outdated version of MSpy from Chris' edits, and instead of me trying to debug everything