Skip to content

Only use the available balance on Coinbase #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freenancial wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Only use the available balance on Coinbase #48

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
790021d
Only use the available balance on Coinbase
freenancial Jan 1, 2021
b451580
Coinbase account doesn't have the "available" field
freenancial Jan 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bitcoin_dca/coinbase_pro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def getCoinbaseAccount(self, currency):

@property
def coinbase_usdc_account(self):
return self.convertRawAccount(self.getCoinbaseAccount("USDC"))
return self.convertRawCoinbaseAccount(self.getCoinbaseAccount("USDC"))

@property
def usd_account(self):
Expand Down Expand Up @@ -187,4 +187,8 @@ def printOrderResult(order_result):

@staticmethod
def convertRawAccount(raw_account):
return Account(id=raw_account["id"], balance=float(raw_account["available"]))

@staticmethod
def convertRawCoinbaseAccount(raw_account):
return Account(id=raw_account["id"], balance=float(raw_account["balance"]))