Debian packaging improvements (module autoloading) #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
(Sorry for the late response) The two commits in this merge request should be in at least two separate MRs. |
Closed
Contributor
Author
|
Hello, Thanks for updating this tool :) I created a separate merge request for just the udev rules: #61 |
This DKMS script will be run when the package is installed. It will run the standard DKMS build steps (compiling the module against the current kernel version), and will additionally: - Load the module immediately - Configure the module to be loaded automatically at boot This is not handled by default by DKMS, because usually, kernel modules are associated with some hardware, and the hardware detection in the kernel will be enough to load the module. But, in the case of tty0tty, there is no associated hardware, and so, the module must be explicitly loaded.
Contributor
Author
|
Now I have removed that part from this pull request, so you can merge them independently. |
pulkomandy
commented
Sep 16, 2024
|
|
||
| DKMS_NAME=tty0tty | ||
| DKMS_PACKAGE_NAME=$DKMS_NAME-dkms | ||
| DKMS_VERSION=1.2 |
Contributor
Author
There was a problem hiding this comment.
This needs to be updated when/if a version 1.3 of tty0tty (orany other new version number) is released. I'm not sure if it is possible to extract this info from somewhere else, what would be considered appropriate here?
Collaborator
|
On Mon, Sep 16, 2024 at 04:02:43AM -0700, Adrien Destugues wrote:
+DKMS_VERSION=1.2
This needs to be updated when/if a version 1.3 of tty0tty (orany
other new version number) is released. I'm not sure if it is possible
to extract this info from somewhere else,
what would be considered appropriate here?
Appropriate would be discussioning it outside this merge request.
Groeten
Geert Stappers
--
Silence is hard to parse
|
stappersg
changed the title
Collaborator
|
For the record: It is lack of resources to merge this request and to undo the not so good parts of the MR. |
Contributor
Author
|
Hello, You requested that I split the merge request in two parts, and I already did that. If you have other requests, please state them, because I cannot work from "there are some parts that are not good". |
Collaborator
|
On Mon, Sep 30, 2024 at 12:06:56AM -0700, Adrien Destugues wrote:
Hello,
Hi there,
You requested that I split the merge request in two parts,
and I already did that.
Acknowledge
If you have other requests, please state them,
because I cannot work from "there are some parts that are not good".
Also true.
The good part: There is `postinst`.
The not so good parts:
- There is no `postrm`.
- The silent "load the kernel module on start up"
- Version number nowhere documented
- The unneeded modification of the .gitignore
The .gitignore modification that I deem unneeded, can I leave out.
If the ignore change is needed, put it in a separate merge request
with a commit message that explains the **why**.
The github comment thread of this "pull request" has already
tipped "this version numberhere, will effect releases". It waits
for a follow-up.
The "load the kernel module" is indeed the purpose of `tty0tty`.
Currently it feels wrong to me how it is done. I might wrong.
I think the what I deem "odd" can be overcome with debconf.
Most likely it is a non-issue. Or an issue that can be addressed
in debian/README
Upon uninstall of the Debian package should the `postinst` be undone.
In a near future is none of the above on **my** priority list.
Groeten
Geert Stappers
--
Silence is hard to parse
|
Collaborator
|
For what is it worth: #69 created tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request changes two things: