Security: Replace JWT tokens in WebSocket URLs with one-time-use tickets #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JWT tokens in WebSocket query params (
?token=...) expose credentials in server logs, proxy logs, and browser history. This PR implements a ticket-based authentication flow where clients first obtain a short-lived ticket via REST, then connect with that ticket.Changes
New ticket service (
WebSocketTicketService)New endpoint
POST /api/auth/ws-ticketAuthorization: Bearer <JWT>header{ success: true, ticket: "<uuid>" }WebSocket handler updates (
ChatWebSocketHandler)extractUsernameFromJWT→extractUserFromTicket?ticket=param instead of?token=anonSessionIdquery param fallback (cookies-only now)Usage
Testing
WebSocketTicketServicecovering ticket generation, validation, consumption, and edge casesWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.