fix(Block Props): improved implementation of getPropValue#525
Open
stravo1 wants to merge 5 commits intofrappe:developfrom
Open
fix(Block Props): improved implementation of getPropValue#525stravo1 wants to merge 5 commits intofrappe:developfrom
getPropValue#525stravo1 wants to merge 5 commits intofrappe:developfrom
Conversation
now props which are dynamic and comesFrom props are also handled
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #525 +/- ##
========================================
Coverage 63.56% 63.56%
========================================
Files 27 27
Lines 2791 2791
========================================
Hits 1774 1774
Misses 1017 1017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously dynamic props which came from other props (not Block Data Script or Page Script) were not resolved properly.
Also, now with
blockUidStore, we no more need to passgetDataScriptValue,getBlockDataScriptValue,defaultPropstogetPropValue, it can infer those automatically.getParentPropnow provides traceback as to which props come from which parent (grandparent) blocks.Misc fixes:
allResolvedPropswould behave unexpectedly if resolved before the BuilderBlock was mounted, fixed that along with the new implementation ofgetPropValue