Skip to content

fix(Block Props): improved implementation of getPropValue#525

Open
stravo1 wants to merge 5 commits intofrappe:developfrom
stravo1:fix-get-prop-value
Open

fix(Block Props): improved implementation of getPropValue#525
stravo1 wants to merge 5 commits intofrappe:developfrom
stravo1:fix-get-prop-value

Conversation

@stravo1
Copy link
Member

@stravo1 stravo1 commented Mar 19, 2026

Previously dynamic props which came from other props (not Block Data Script or Page Script) were not resolved properly.

Also, now with blockUidStore, we no more need to pass getDataScriptValue, getBlockDataScriptValue, defaultProps to getPropValue, it can infer those automatically.

getParentProp now provides traceback as to which props come from which parent (grandparent) blocks.

Misc fixes:

  • allResolvedProps would behave unexpectedly if resolved before the BuilderBlock was mounted, fixed that along with the new implementation of getPropValue
  • somehow we deleted the opposite of what was required (BuilderBlock.vue - Line 182)
  • using separate watchEffects for the three properties, keeping all in one sometimes caused loops.

@stravo1 stravo1 requested a review from surajshetty3416 March 19, 2026 07:37
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.56%. Comparing base (b4c1f00) to head (ad716a7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #525   +/-   ##
========================================
  Coverage    63.56%   63.56%           
========================================
  Files           27       27           
  Lines         2791     2791           
========================================
  Hits          1774     1774           
  Misses        1017     1017           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant