fix: a "complete" URLObject in target should be left as it is

[normanzb]

Change Summary

This PR avoids pathname overwriting when passing in an URLObject with all necessary props to generateTargetURL().

If the user passing in a URL object with all props required to construct a full URL, that means they want to go straight to there without modification. But current behaviour of generateTargetURL() overwrite its pathname by prepending the pathname of baseUrl

Merge Checklist

• PR has a Changeset
• PR includes documentation if necessary
• PR updates the boilerplates if necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
frames-js	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 25, 2024 10:00am
framesjs-debugger	❌ Failed (Inspect)			Nov 25, 2024 10:00am
framesjs-examples	❌ Failed (Inspect)			Nov 25, 2024 10:00am

[michalkvasnicak]

You should also check if the values are set right? URLObject is just saying that there are properties but their values can be empty right?

Also wouldn't it make sense to also allow URL class instance?

[michalkvasnicak]

Tha last point about URL instance is for generateTargetUrl function. baseUrl is typed like that.

[normanzb]

URLObject is already compatible with URL, the user is able to pass an URL object. Also to add URL explicitly the whole call stacks will be updated. as it is gaining nothing I think let's leave that part out?

I've updated value check into isUrlObjectComplete, pls have a look @michalkvasnicak , thanks!