Skip to content

fix: prevent long urls in cast embeds from overflowing #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephancill merged 1 commit into from
Nov 18, 2024
Merged

fix: prevent long urls in cast embeds from overflowing #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hungry-actors-call.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@frames.js/debugger": patch
---

fix(debugger): prevent long urls in cast embeds from overflowing
24 changes: 14 additions & 10 deletions packages/debugger/app/components/cast-composer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export const CastComposer = React.forwardRef<
{state.embeds.length > 0 ? (
<ul className="flex flex-col gap-2">
{state.embeds.slice(0, 2).map((embed, index) => (
<li key={`${embed}-${index}`}>
<li key={`${embed}-${index}`} className="flex flex-grow">
<CastEmbedPreview
farcasterFrameConfig={farcasterFrameConfig}
onRemove={() => {
Expand Down Expand Up @@ -234,20 +234,24 @@ function CastEmbedPreview({
allowPartialFrame
onError={handleFrameError}
/>
<span className="ml-auto truncate text-sm text-slate-400">{url}</span>
<WithTooltip tooltip={url}>
<span className="ml-auto truncate text-sm text-slate-400 max-w-full">
{url}
</span>
</WithTooltip>
</div>
);
}

return (
<span className="flex gap-2 w-full items-center">
<div className="flex flex-grow items-center gap-4 bg-slate-100 p-2 rounded">
<div className="bg-slate-200 rounded p-4">
<GlobeIcon className="flex-shrink-0" />
</div>
<span className="truncate text-sm text-slate-800 flex-grow">{url}</span>
<div className="flex gap-2 text-slate-300">{buttons}</div>
<div className="flex gap-2 w-full max-w-full items-center bg-slate-100 p-2 rounded">
<div className="bg-slate-200 rounded p-4">
<GlobeIcon className="flex-shrink-0" />
</div>
</span>
<WithTooltip tooltip={url}>
<span className="truncate text-sm text-slate-800 flex-grow">{url}</span>
</WithTooltip>
<div className="flex gap-2 text-slate-300">{buttons}</div>
</div>
);
}