-
Notifications
You must be signed in to change notification settings - Fork 0
fix: support multiple internal contact relations #1331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3d0f140 to
ded42a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Marwaxhello
reviewed
Jan 6, 2026
Contributor
Marwaxhello
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik heb Ali's branch getest in Strapi dashboard
Contactinformatie
- De labels voor contactinformatie kloppen volgens de feedback van Marleen.
- De juiste rollen die aangevinkt moeten zijn, zijn gecontroleerd en correct ingesteld.
- De koppeling met de overige objecten API is getest door UUID’s uit Strapi op te vragen via het
getObjectByIdendpoint (Swagger UI), waarbij een geldige response werd ontvangen.
Contactinformatie intern
- De interne informatie is correct gekoppeld aan contact information internal.
- De relatie werkt zoals verwacht en de preview wordt correct weergegeven in Strapi.
VAC
- Dezelfde controles zijn uitgevoerd voor VAC.
- Ook hier zijn de koppelingen correct en wordt de preview correct weergegeven in het dashboard.
ded42a3 to
dffe42f
Compare
dffe42f to
b69640c
Compare
Robbert
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.