Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 80.06% 80.38% +0.32%
==========================================
Files 33 34 +1
Lines 3110 3161 +51
==========================================
+ Hits 2490 2541 +51
Misses 620 620
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also renamed self.glob to self.pattern.
There was a problem hiding this comment.
Tested and it works very nicely. At first I didn't install fastavro so when reading some *.avro files it threw unhelpful messages..
So, I wonder if we need to make the file magic detection just raise errors instead of failing silently. Anyway, that is for future reference and not this PR.
Other than that, I have some small suggestions and then it looks good to go!
f286733 to
4f03249
Compare
yunzheng
left a comment
There was a problem hiding this comment.
I have some problems writing a gzipped file to a GCS bucket
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 81.64% 81.94% +0.30%
==========================================
Files 34 35 +1
Lines 3307 3362 +55
==========================================
+ Hits 2700 2755 +55
Misses 607 607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@yunzheng To support transparent compression when writing to filelike objects, I've added An unfortunate consequence is that the |
Depends on #83.
This pull request adds a Google Cloud Storage adapter for flow.record. It supports both reading from and writing to Google Cloud Storage in a streaming manner.