Skip to content

Add missing target fields#1738

Merged
Schamper merged 1 commit intofox-it:mainfrom
respondersGY:fix/missing_target_fields
Apr 30, 2026
Merged

Add missing target fields#1738
Schamper merged 1 commit intofox-it:mainfrom
respondersGY:fix/missing_target_fields

Conversation

@respondersGY
Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 25, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing respondersGY:fix/missing_target_fields (72021d9) with main (22e7a81)

Open in CodSpeed

@Schamper
Copy link
Copy Markdown
Member

@Miauwkeru are the broken tests because of fox-it/dissect.eventlog#32?

@Miauwkeru
Copy link
Copy Markdown
Contributor

@Miauwkeru are the broken tests because of fox-it/dissect.eventlog#32?

I'll take a look, I thought I had covered the changes with #1737 but I might have been mistaken.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (22e7a81) to head (72021d9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1738   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         403      403           
  Lines       35378    35378           
=======================================
  Hits        28754    28754           
  Misses       6624     6624           
Flag Coverage Δ
unittests 81.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper merged commit 14c052c into fox-it:main Apr 30, 2026
46 of 66 checks passed
@respondersGY respondersGY deleted the fix/missing_target_fields branch April 30, 2026 18:24
@respondersGY
Copy link
Copy Markdown
Contributor Author

Thanks for merging the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants