Fix crash in linux.environ plugin when environ file is missing#1504
Merged
Schamper merged 6 commits intofox-it:mainfrom Feb 11, 2026
Merged
Fix crash in linux.environ plugin when environ file is missing#1504Schamper merged 6 commits intofox-it:mainfrom
linux.environ plugin when environ file is missing#1504Schamper merged 6 commits intofox-it:mainfrom
Conversation
Contributor
Author
Schamper
requested changes
Feb 9, 2026
Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
Schamper
requested changes
Feb 11, 2026
Schamper
approved these changes
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1504 +/- ##
==========================================
- Coverage 80.94% 80.93% -0.02%
==========================================
Files 397 397
Lines 34892 34893 +1
==========================================
- Hits 28244 28240 -4
- Misses 6648 6653 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Matthijsy
pushed a commit
to Matthijsy/dissect.target
that referenced
this pull request
Mar 2, 2026
…ox-it#1504) Co-authored-by: Erik Schamper <1254028+Schamper@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR fixes a bug in the
linux.environplugin where attempting to parse the environment of a process would crash if the/proc/<pid>/environfile does not exist (e.g., kernel threads or race conditions during process termination).Changes:
dissect/target/plugins/os/unix/linux/proc.py: Added an explicit.exists()check in_parse_environbefore attempting to read the file. It now gracefully returns/skips instead of raising an exception.tests/conftest.py: Updated thefs_linux_procfixture to simulate a scenario where a process in/proclacks anenvironfile (conditional mapping).tests/.../test_environ.py:4to3(since one process is now correctly skipped due to the missing file).Testing: