Skip to content

Improve VDI#72

Open
Schamper wants to merge 5 commits intomainfrom
improve-vdi
Open

Improve VDI#72
Schamper wants to merge 5 commits intomainfrom
improve-vdi

Conversation

@Schamper
Copy link
Member

Closes #55, but also improves a whole bunch of other things on VDI parsing.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 90.90909% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.17%. Comparing base (6f2d5ab) to head (809f272).

Files with missing lines Patch % Lines
dissect/hypervisor/disk/vdi.py 90.54% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   78.64%   80.17%   +1.53%     
==========================================
  Files          26       26              
  Lines        2332     2371      +39     
==========================================
+ Hits         1834     1901      +67     
+ Misses        498      470      -28     
Flag Coverage Δ
unittests 80.17% <90.90%> (+1.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper force-pushed the improve-vdi branch 3 times, most recently from 2aef79f to c9e52b0 Compare December 24, 2025 14:06
@Schamper Schamper mentioned this pull request Dec 30, 2025
3 tasks
twiggler
twiggler previously approved these changes Feb 5, 2026
…/test.vmcx,tests/_data/descriptor/vbox/GOAD-DC01.vbox,tests/_data/descriptor/vbox/encrypted.vbox,tests/_data/descriptor/vmx/encrypted.vmx,tests/_data/disk/asif/basic.asif.gz,tests/_data/disk/hdd/expanding.hdd/DiskDescriptor.xml,tests/_data/disk/hdd/expanding.hdd/expanding.hdd,tests/_data/disk/hdd/expanding.hdd/expanding.hdd.0.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/plain.hdd/DiskDescriptor.xml,tests/_data/disk/hdd/plain.hdd/plain.hdd,tests/_data/disk/hdd/plain.hdd/plain.hdd.0.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/split.hdd/DiskDescriptor.xml,tests/_data/disk/hdd/split.hdd/split.hdd,tests/_data/disk/hdd/split.hdd/split.hdd.0.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/split.hdd/split.hdd.1.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/split.hdd/split.hdd.2.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/split.hdd/split.hdd.3.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/split.hdd/split.hdd.4.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/hdd/split.hdd/split.hdd.5.{5fbaabe3-6958-40ff-92a7-860e329aab41}.hds.gz,tests/_data/disk/qcow2/backing-chain-1.qcow2.gz,tests/_data/disk/qcow2/backing-chain-2.qcow2.gz,tests/_data/disk/qcow2/backing-chain-3.qcow2.gz,tests/_data/disk/qcow2/basic-zstd.qcow2.gz,tests/_data/disk/qcow2/basic.qcow2.gz,tests/_data/disk/qcow2/data-file.bin.gz,tests/_data/disk/qcow2/data-file.qcow2.gz,tests/_data/disk/qcow2/snapshot.qcow2.gz,tests/_data/disk/vdi/basic.vdi.gz,tests/_data/disk/vhd/dynamic.vhd.gz,tests/_data/disk/vhd/fixed.vhd.gz,tests/_data/disk/vhdx/differencing.avhdx.gz,tests/_data/disk/vhdx/dynamic.vhdx.gz,tests/_data/disk/vhdx/fixed.vhdx.gz,tests/_data/disk/vmdk/sesparse.vmdk.gz,tests/_data/util/envelope/encryption.info,tests/_data/util/envelope/local.tgz.ve,tests/_data/util/vmtar/test.vgz: convert to Git LFS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change VDI implementation to return stream on .open() instead of being a stream

2 participants