-
Notifications
You must be signed in to change notification settings - Fork 225
fix: Reference to undefined setting: scriptedKeepTempDirectory #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f102dd4
[2.x] fix: Reference to undefined setting: scriptedKeepTempDirectory
EndlessLucky c552b00
fix ci issue
EndlessLucky e0e44e5
fix ubuntu-test issue
EndlessLucky c89bbcb
fix the feedback
EndlessLucky 0d1b5fe
fix the ubuntu issue
EndlessLucky 105296c
fix ubuntu issue
EndlessLucky 259beda
fix ubuntu test issue
EndlessLucky 54b3e1c
fix ubuntu17 ci issue
EndlessLucky 1c73ba7
fix cl issue
EndlessLucky 70fef44
fix makesite issue
EndlessLucky 165169a
fix ci test issue
EndlessLucky 8faaa9a
fix ci test issue
EndlessLucky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| enablePlugins(ScriptedPlugin) | ||
|
|
||
| Compile / unmanagedSourceDirectories += baseDirectory.value | ||
|
|
||
| // ScriptedPlugin 1.x pulls scripted-sbt for this Scala binary version (2.12 is always published). | ||
| scalaVersion := "2.12.21" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,7 @@ | ||
| enablePlugins(ScriptedPlugin) | ||
|
|
||
| scalaVersion := "2.12.21" | ||
|
|
||
| TaskKey[Unit]("writeInvalidFile") := { | ||
| IO.write(file("src/main/g8/src/test/scala/invalid.scala"), "invalid file") | ||
| } | ||
|
|
||
| val javaVmArgs: List[String] = { | ||
| import scala.collection.JavaConverters._ | ||
| java.lang.management.ManagementFactory.getRuntimeMXBean.getInputArguments.asScala.toList | ||
| } | ||
|
|
||
| scriptedLaunchOpts ++= javaVmArgs.filter(a => Seq("-Xmx", "-Xms", "-XX").exists(a.startsWith)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
plugin/src/sbt-test/giter8/simple/src/main/g8/default.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| name = New Project | ||
| unfiltered = maven(net.databinder, unfiltered_2.11) | ||
| dispatch = maven(net.databinder.dispatch, dispatch-core_2.11) | ||
| unfiltered = 0.8.4 | ||
| dispatch = 0.11.3 | ||
| organization = com.example | ||
| package = $organization$.$name;format="norm,word"$ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| > show scriptedDependencies | ||
| > g8Test | ||
| > writeInvalidFile | ||
| -> g8Test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,3 @@ | ||
| val javaVmArgs: List[String] = { | ||
| import scala.collection.JavaConverters._ | ||
| java.lang.management.ManagementFactory.getRuntimeMXBean.getInputArguments.asScala.toList | ||
| } | ||
| enablePlugins(ScriptedPlugin) | ||
|
|
||
| scriptedLaunchOpts ++= javaVmArgs.filter(a => Seq("-Xmx", "-Xms", "-XX").exists(a.startsWith)) | ||
| scalaVersion := "2.12.21" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| addSbtPlugin("org.foundweekends.giter8" % "sbt-giter8" % System.getProperty("plugin.version")) | ||
|
|
||
| libraryDependencies += "org.scala-sbt" %% "scripted-plugin" % sbtVersion.value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| name := "Example SBT project" | ||
|
|
||
| scalaVersion := "2.11.12" | ||
| // Scripted smoke-test projects must declare a Scala version. | ||
| // Pin to a version compatible with the CI JDK (17+). | ||
| scalaVersion := "2.13.14" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't disable sbt 2 tests.