feat(forge): migrate forge init to output channel contract#14958
Open
stevencartavia wants to merge 2 commits into
Open
feat(forge): migrate forge init to output channel contract#14958stevencartavia wants to merge 2 commits into
stevencartavia wants to merge 2 commits into
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr and
mattsse
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
forge initper docs/dev/output-channels.md: status prose ("Initializing …", "Initialized forge project") moves from stdout to stderr viash_status!.forge initproduces no machine-readable data, so stdout is now empty.crates/forge/src/cmd/init.rs: threesh_println!→sh_status!.docs/dev/output-channels.md: row flipped tomigrated.cmd.rs,debug.rs,script.rs: init prose snapshots relocated from.stdout_eqto.stderr_eq(with...between Initializing/Initialized to tolerate git's clone output on the same channel).fail_init_nonexistent_templateupdated to include the new stderr line. Added focused lock-in testinit_status_on_stderr.