refactor(anvil): make MaybeImpersonatedTransaction generic#13654
Merged
onbjerg merged 1 commit intofoundry-rs:masterfrom Mar 6, 2026
Merged
refactor(anvil): make MaybeImpersonatedTransaction generic#13654onbjerg merged 1 commit intofoundry-rs:masterfrom
onbjerg merged 1 commit intofoundry-rs:masterfrom
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
ImpersonatedTransaction<T>toMaybeImpersonatedTransaction<T = FoundryTxEnvelope>, eliminating the type alias.Replaces the concrete
impl MaybeImpersonatedTransaction<FoundryTxEnvelope>block with a generic impl bounded onSignerRecoverable + TxHashRef + Encodable, moving the impersonated hash logic out ofFoundryTxEnvelopeand into the wrapper. Implements both traits onFoundryTxEnvelopeto satisfy the bounds.