refactor(evm): replace NestedEvmExt trait with free function#13652
Merged
mattsse merged 2 commits intofoundry-rs:masterfrom Mar 7, 2026
Merged
refactor(evm): replace NestedEvmExt trait with free function#13652mattsse merged 2 commits intofoundry-rs:masterfrom
mattsse merged 2 commits intofoundry-rs:masterfrom
Conversation
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
figtracer
force-pushed
the
fig/nested-evm-generic-factory
branch
3 times, most recently
from
d775a1c to
fc5b5b8
Compare
figtracer
commented
Mar 6, 2026
figtracer
force-pushed
the
fig/nested-evm-generic-factory
branch
from
fc5b5b8 to
31da635
Compare
figtracer
changed the title
NestedEvmExt network-agnostic
2 tasks
mablr
reviewed
Mar 6, 2026
Collaborator
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
Free function with_cloned_context looks good to me.
I'm not sure about adding another abstraction via CheatsCtxExt trait for the moment, as the bounds are still subject to change (eg: FoundryContextExt support only Ethereum EVM). Let's stabilize this first? wdyt @figtracer
Collaborator
Author
imo we should proceed with this if it makes sense atm, if anything changes we come back to it? i believe that having this extra-bounded version of it can help to frame the problem in the future if that makes sense and we stack the more refined ergonomics on top of it |
figtracer
force-pushed
the
fig/nested-evm-generic-factory
branch
3 times, most recently
from
dad5c49 to
af38a4b
Compare
Remove `get_inspector()` which returned `Box<dyn InspectorExt>` (Eth-bound). Instead, the executor now assembles the inspector internally and owns the entire operation: - `with_nested_evm`: runs closure with nested EVM cloned from context - `with_fresh_nested_evm`: runs closure with fresh EVM from raw db+env - `transact_on_db`: replays historical transaction - `transact_from_tx_on_db`: executes a TransactionRequest `InspectorExt` no longer appears on the `CheatcodesExecutor` trait boundary. It only lives inside the impl bodies of `InspectorStackInner` and `TransparentCheatcodesExecutor`.
Remove `InspectorExt` from `NestedEvmExt` entirely. The trait now handles only network-agnostic work (clone env + journal, split db borrow, write back). Callers build their own EVM inside a callback that receives `(&mut dyn DatabaseExt, Env, JournaledState)`. - Remove `new_nested_evm` from `NestedEvmExt` (callers call `new_evm_with_inspector` directly) - Remove `new_evm_with_existing_context` (dead code) - Update `InspectorStackInner` and `TransparentCheatcodesExecutor` to build `FoundryEvm` inside the callback - `CheatsCtxExt: NestedEvmExt` is now fully network-agnostic
figtracer
force-pushed
the
fig/nested-evm-generic-factory
branch
from
af38a4b to
c9493ac
Compare
mattsse
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NestedEvmExttrait withwith_cloned_contextfree function(&mut dyn DatabaseExt, Env, JournaledState)new_nested_evmfrom trait andnew_evm_with_existing_context(dead code)CheatsCtxExtto justFoundryContextExtwith journal/db bounds (one less trait)Stack: #13650 → #13651 → PR 3/3
Depends on #13651
Test plan
cargo checkpasses (zero errors, zero warnings)InspectorStackInner,TransparentCheatcodesExecutor