fix(traces): fix rate limit backoff in ExternalFetcher#13604
Open
gutonosa wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(traces): fix rate limit backoff in ExternalFetcher#13604gutonosa wants to merge 1 commit intofoundry-rs:masterfrom
gutonosa wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rate limit backoff in
ExternalFetchernever actually waits.tokio::time::interval()fires its first tick immediately, so after a 429 the loop just takes the interval out, seesReady, drops it, and retries with no delay. Cycle repeats on every rate limit hit.What happens:
backoff = Some(interval(5s)).take()pulls it out,poll_tick()→ instantReady, if-let falls through, interval droppedqueue_next_reqs()fires immediately → another 429 → repeatFix:
interval_at(now + timeout, timeout)so the first tick respects the delay.