Skip to content

Conversation

@leovct
Copy link
Contributor

@leovct leovct commented Dec 1, 2025

Closes #12676

MNEMONIC="code code code code code code code code code code code quality"
cast wallet derive "$MNEMONIC" --accounts 3 --insecure --json

will produce:

[
  {
    "address": "0x85dA99c8a7C2C95964c8EfD687E95E632Fc533D6",
    "private_key": "0x42b6e34dc21598a807dc19d7784c71b2a7a01f6480dc6f58258f78e539f1a1fa"
  },
  {
    "address": "0x125FB391bA829e0865963D3B91711610049a9e78",
    "private_key": "0x0903a9a721167e2abaa0a33553cbeb209dc9300d28e4e4d6d2fac2452f93e357"
  },
  {
    "address": "0x964ec59D0E05Db08440c822d7C588e63BBDE8c4e",
    "private_key": "0x6421222a9964cbe1b411191dcac1afda173ed99346c47302c6fe88f65d83583e"
  }
]

@leovct
Copy link
Contributor Author

leovct commented Dec 1, 2025

@zerosnacks would you mind re-triggering the failing job? I believe it failed because of an unrelated flaky test - thank you!

@zerosnacks
Copy link
Member

lgtm! would you mind adding a test case for the text and json variants?

@leovct
Copy link
Contributor Author

leovct commented Dec 2, 2025

wallet derive tests seem to pass but the ci is failing because of a flaky test once again

PASS [   0.240s] ( 593/1640) cast::cli wallet_derive_mnemonic_insecure
PASS [   0.245s] ( 594/1640) cast::cli wallet_derive_mnemonic
PASS [   0.238s] ( 595/1640) cast::cli wallet_derive_mnemonic_insecure_json
PASS [   0.305s] ( 596/1640) cast::cli wallet_change_password
PASS [   3.836s] ( 597/1640) cast::cli run_succeeds
PASS [   0.242s] ( 598/1640) cast::cli wallet_derive_mnemonic_json

zerosnacks
zerosnacks previously approved these changes Dec 2, 2025
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Lgtm, CI failure unrelated

@zerosnacks zerosnacks enabled auto-merge December 2, 2025 08:48
@zerosnacks zerosnacks added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@zerosnacks zerosnacks added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@grandizzy grandizzy added this pull request to the merge queue Dec 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2025
@grandizzy
Copy link
Collaborator

it seems like the CI failure for Win is a legit one, need to investigate it why happens

@leovct
Copy link
Contributor Author

leovct commented Dec 3, 2025

it seems like the CI failure for Win is a legit one, need to investigate it why happens

I tried to rebase but CI is now failing because of another error :(

@grandizzy
Copy link
Collaborator

grandizzy commented Dec 3, 2025

it seems like the CI failure for Win is a legit one, need to investigate it why happens

I tried to rebase but CI is now failing because of another error :(

checking, most probably related to post release support added in svm-rs and now 0.8.31 out

@grandizzy
Copy link
Collaborator

#12867 should fix the win failure, will rebase this PR when merged

DaniPopes
DaniPopes previously approved these changes Dec 21, 2025
@DaniPopes DaniPopes added this pull request to the merge queue Dec 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2025
@DaniPopes DaniPopes added this pull request to the merge queue Dec 21, 2025
@grandizzy
Copy link
Collaborator

needs #12903 to pass win

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2025
@DaniPopes DaniPopes enabled auto-merge December 21, 2025 19:23
@DaniPopes DaniPopes added this pull request to the merge queue Dec 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2025
@DaniPopes DaniPopes added this pull request to the merge queue Dec 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2025
@DaniPopes DaniPopes dismissed stale reviews from mattsse, zerosnacks, and themself via 9ced08f December 21, 2025 23:13
@DaniPopes DaniPopes enabled auto-merge December 21, 2025 23:15
DaniPopes
DaniPopes previously approved these changes Dec 21, 2025
@DaniPopes DaniPopes added this pull request to the merge queue Dec 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2025
@DaniPopes DaniPopes added this pull request to the merge queue Dec 22, 2025
Merged via the queue into foundry-rs:master with commit 57ded5a Dec 22, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

feature(cast): extend cast wallet list or add a new command to support deriving accounts from a mnemonic

5 participants